third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 1367853002: Move GeolocationDispatcher into blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1367853002: Move GeolocationDispatcher into blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/geolocation/Geolocation.cpp ('K') | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/Source/web/web.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index e702d8156f4ef366a7a13832a6a2f6287b3935bf..4edc92c466b8cbcc1bdd0248d8efd9ae022a1172 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -156,7 +156,6 @@

#include "modules/app_banner/AppBannerController.h"

#include "modules/audio_output_devices/AudioOutputDeviceClient.h"

#include "modules/bluetooth/BluetoothSupplement.h"

-#include "modules/geolocation/GeolocationController.h"

#include "modules/installedapp/InstalledAppController.h"

#include "modules/notifications/NotificationPermissionClient.h"

#include "modules/permissions/PermissionController.h"

@@ -220,7 +219,6 @@

#include "web/AudioOutputDeviceClientImpl.h"

#include "web/CompositionUnderlineVectorBuilder.h"

#include "web/FindInPageCoordinates.h"

-#include "web/GeolocationClientProxy.h"

#include "web/IndexedDBClientImpl.h"

#include "web/LocalFileSystemClient.h"

#include "web/MIDIClientProxy.h"

@@ -1420,7 +1418,6 @@ WebLocalFrameImpl::WebLocalFrameImpl(WebTreeScopeType scope, WebFrameClient* cli

, m_contentSettingsClient(0)

, m_inputEventsScaleFactorForEmulation(1)

, m_userMediaClientImpl(this)

- , m_geolocationClientProxy(GeolocationClientProxy::create(client ? client->geolocationClient() : 0))

, m_webDevToolsFrontend(0)

, m_selfKeepAlive(this)

{

@@ -1446,7 +1443,6 @@ DEFINE_TRACE(WebLocalFrameImpl)

visitor->trace(m_devToolsAgent);

visitor->trace(m_textFinder);

visitor->trace(m_printContext);

- visitor->trace(m_geolocationClientProxy);

visitor->trace(m_contextMenuNode);

visitor->template registerWeakMembers<WebFrame, &WebFrame::clearWeakFrames>(this);

WebFrame::traceFrames(visitor, this);

@@ -1466,8 +1462,6 @@ void WebLocalFrameImpl::setCoreFrame(LocalFrame* frame)

provideNotificationPermissionClientTo(*m_frame, NotificationPermissionClientImpl::create());

provideUserMediaTo(*m_frame, &m_userMediaClientImpl);

- provideGeolocationTo(*m_frame, m_geolocationClientProxy.get());

- m_geolocationClientProxy->setController(GeolocationController::from(m_frame.get()));

provideMIDITo(*m_frame, MIDIClientProxy::create(m_client ? m_client->webMIDIClient() : nullptr));

provideIndexedDBClientTo(*m_frame, IndexedDBClientImpl::create());

provideLocalFileSystemTo(*m_frame, LocalFileSystemClient::create());