Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/invalid-internals-arguments.js

Issue 1367853002: Move GeolocationDispatcher into blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/invalid-internals-arguments.js
diff --git a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/invalid-internals-arguments.js b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/invalid-internals-arguments.js
index 81010c6dda8557d561385dd83aab743b1d78e6f6..3e186cca0d56b2d575e0d48ed3542fe64cbb2bee 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/invalid-internals-arguments.js
+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/invalid-internals-arguments.js
@@ -1,26 +1,18 @@
description("Verify that using invalid or detached documents on internal test methods does not crash.");
Michael van Ouwerkerk 2016/05/04 13:52:16 Please rename this file to invalid-mock-arguments.
Sam McNally 2016/05/05 11:50:23 This isn't used anymore and should have been delet
-// The internals object and these test methods aren't available in production
+// The mock object and these test methods aren't available in production
// builds, but they are exposed to fuzzers.
-if (!window.testRunner || !window.internals)
- debug('This test can not run without testRunner or internals');
+if (!window.testRunner || !window.mojo)
+ debug('This test can not run without testRunner or mojo');
-shouldThrow("internals.setGeolocationClientMock(null);");
-shouldThrow("internals.setGeolocationPosition(null, 1, 2, 3);");
-shouldThrow("internals.setGeolocationPermission(window.notThere, true);");
-shouldThrow("internals.setGeolocationPositionUnavailableError(null, 'not available');");
-shouldThrow("internals.numberOfPendingGeolocationPermissionRequests(null)");
+shouldThrow("mock.setGeolocationPosition(null, 1, 2, 3);");
+shouldThrow("mock.setGeolocationPermission(window.notThere, true);");
+shouldThrow("mock.setGeolocationPositionUnavailableError(null, 'not available');");
+shouldThrow("mock.numberOfPendingGeolocationPermissionRequests(null)");
var ifr = document.getElementById("ifr");
var iframe = ifr.contentWindow;
-// Must access it first so it exists, we cannot get internals from a detached frame window.
-var iframeInternals = iframe.internals;
+// Must access it first so it exists, we cannot get mock from a detached frame window.
+var iframeInternals = iframe.mock;
ifr.remove();
-
-// Verify that detached documents do not crash.
-shouldBeUndefined("iframeInternals.setGeolocationClientMock(iframe.document)");
-shouldBeUndefined("iframeInternals.setGeolocationPosition(iframe.document, 1, 2, 3)");
-shouldBeUndefined("iframeInternals.setGeolocationPermission(iframe.document, true)");
-shouldBeUndefined("iframeInternals.setGeolocationPositionUnavailableError(iframe.document, 'not available')");
-shouldBe("iframeInternals.numberOfPendingGeolocationPermissionRequests(iframe.document)", "-1");

Powered by Google App Engine
This is Rietveld 408576698