content/browser/permissions/permission_service_impl.cc - Issue 1367853002: Move GeolocationDispatcher into blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/permissions/permission_service_impl.cc

Issue 1367853002: Move GeolocationDispatcher into blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/permissions/permission_service_impl.cc

diff --git a/content/browser/permissions/permission_service_impl.cc b/content/browser/permissions/permission_service_impl.cc

index c7f92a8d9e92b7635f1b6b14bc81e028e9b756e0..5591797df1d7b4a6efc73c1ff41984d59c23df70 100644

--- a/content/browser/permissions/permission_service_impl.cc

+++ b/content/browser/permissions/permission_service_impl.cc

@@ -107,6 +107,7 @@ PermissionServiceImpl::~PermissionServiceImpl() {

}

void PermissionServiceImpl::OnConnectionError() {

+ CancelPendingOperations();

Michael van Ouwerkerk 2016/05/04 13:52:16 nit: This might make sense in a separate patch for

Sam McNally 2016/05/05 11:50:23 Done.

context_->ServiceHadConnectionError(this);

// After that call, |this| will be deleted.

}