Issue 136783008: Move m_shouldOnlyIncludeDirectChildren member from LiveNodeListBase to HTMLCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136783008: Move m_shouldOnlyIncludeDirectChildren member from LiveNodeListBase to HTMLCollection (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
esprehn, adamk

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move m_shouldOnlyIncludeDirectChildren member from LiveNodeListBase to HTMLCollection Move m_shouldOnlyIncludeDirectChildren member from LiveNodeListBase to HTMLCollection as it is only useful to HTMLCollection and not LiveNodeList. This is always false for LiveNodeList now that ChildNodeList no longer subclasses LiveNodeList after r166565. A shouldOnlyIncludeDirectChildren() method is added to LiveNodeList which is inlined and returns false unconditionally. This method is called from templated methods in LiveNodeListBase and therefore the compiler will be able to optimize the branching out in the LiveNodeList specializations of these methods. R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166653

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	Source/core/dom/LiveNodeList.h	View	5 chunks	+3 lines, -5 lines	0 comments	Download
M	Source/core/html/HTMLCollection.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/136783008/1

6 years, 10 months ago (2014-02-06 18:23:16 UTC) #4

Message was sent while issue was closed.

Change committed as 166653

Expand Messages | Collapse Messages