Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: LayoutTests/fast/forms/week/week-stepup-stepdown.html

Issue 136783006: Upgrade stepUp()/stepDown() implementation to match spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: applyStep(): add missing EventQueueScope Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/forms/week/week-stepup-stepdown.html
diff --git a/LayoutTests/fast/forms/week/week-stepup-stepdown.html b/LayoutTests/fast/forms/week/week-stepup-stepdown.html
index ccb4dbfacd513909d39082ca992a02a4302575e2..a31939b24c68baa1d301011276cea9513a1235f6 100644
--- a/LayoutTests/fast/forms/week/week-stepup-stepdown.html
+++ b/LayoutTests/fast/forms/week/week-stepup-stepdown.html
@@ -7,7 +7,7 @@
<p id="description"></p>
<div id="console"></div>
<script>
-description('Check stepUp() and stepDown() bahevior for type=week.');
+description('Check stepUp() and stepDown() behavior for type=week.');
var input = document.createElement('input');
@@ -38,30 +38,30 @@ function stepDown(value, step, min, optionalStepCount) {
input.type = 'week';
debug('Invalid value');
-shouldThrow('stepUp("", null, null)');
-shouldThrow('stepDown("", null, null)');
+shouldBeEqualToString('stepUp("", null, null)', '1970-W02');
+shouldBeEqualToString('stepDown("", null, null)', '1970-W01');
debug('Non-number arguments');
-shouldBe('stepUp("2010-W02", null, null, "0")', '"2010-W02"');
-shouldBe('stepDown("2010-W02", null, null, "0")', '"2010-W02"');
-shouldBe('stepUp("2010-W02", null, null, "foo")', '"2010-W02"');
-shouldBe('stepDown("2010-W02", null, null, "foo")', '"2010-W02"');
-shouldBe('stepUp("2010-W02", null, null, null)', '"2010-W02"');
-shouldBe('stepDown("2010-W02", null, null, null)', '"2010-W02"');
+shouldBeEqualToString('stepUp("2010-W02", null, null, "0")', '2010-W02');
+shouldBeEqualToString('stepDown("2010-W02", null, null, "0")', '2010-W02');
+shouldBeEqualToString('stepUp("2010-W02", null, null, "foo")', '2010-W02');
+shouldBeEqualToString('stepDown("2010-W02", null, null, "foo")', '2010-W02');
+shouldBeEqualToString('stepUp("2010-W02", null, null, null)', '2010-W02');
+shouldBeEqualToString('stepDown("2010-W02", null, null, null)', '2010-W02');
debug('Normal cases');
-shouldBe('stepUp("2010-W02", null, null)', '"2010-W03"');
-shouldBe('stepDown("2010-W02", null, null)', '"2010-W01"');
-shouldBe('stepUp("2010-W02", null, null, 10)', '"2010-W12"');
-shouldBe('stepDown("2010-W02", null, null, 11)', '"2009-W44"');
-shouldBe('stepUp("1970-W01", "4", null, 2)', '"1970-W09"');
-shouldBe('stepDown("1970-W01", "4", null, 3)', '"1969-W41"');
+shouldBeEqualToString('stepUp("2010-W02", null, null)', '2010-W03');
+shouldBeEqualToString('stepDown("2010-W02", null, null)', '2010-W01');
+shouldBeEqualToString('stepUp("2010-W02", null, null, 10)', '2010-W12');
+shouldBeEqualToString('stepDown("2010-W02", null, null, 11)', '2009-W44');
+shouldBeEqualToString('stepUp("1970-W01", "4", null, 2)', '1970-W09');
+shouldBeEqualToString('stepDown("1970-W01", "4", null, 3)', '1969-W41');
debug('Step=any');
shouldThrow('stepUp("2010-W02", "any", null)');
shouldThrow('stepDown("2010-W02", "any", null)');
debug('Overflow/underflow');
-shouldThrow('stepUp("2010-W02", "3.40282346e+38", null)');
-shouldThrow('stepDown("2010-W02", "3.40282346e+38", null)');
-shouldThrow('stepUp("2010-W02", "1", "2010-W02")');
-shouldThrow('stepDown("2010-W02", "1", "2010-W02")');
+shouldBeEqualToString('stepUp("2010-W02", "3.40282346e+38", null)', '275760-W37');
+shouldBeEqualToString('stepDown("2010-W02", "3.40282346e+38", null)', '1970-W01');
+shouldBeEqualToString('stepUp("2010-W02", "1", "2010-W02")', '2010-W02');
+shouldBeEqualToString('stepDown("2010-W02", "1", "2010-W02")', '2010-W02');
debug('');
</script>

Powered by Google App Engine
This is Rietveld 408576698