Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html

Issue 136783006: Upgrade stepUp()/stepDown() implementation to match spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: applyStep(): add missing EventQueueScope Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html
diff --git a/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html b/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html
index dad52e5a5254ed358b5bf4b7479ce5c50d9ba03d..8e05254137e8df167ac83dd0c551aea6aab80252 100644
--- a/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html
+++ b/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html
@@ -7,7 +7,7 @@
<p id="description"></p>
<div id="console"></div>
<script>
-description('Check stepUp() and stepDown() bahevior for type=datetime-local.');
+description('Check stepUp() and stepDown() behavior for type=datetime-local.');
var input = document.createElement('input');
@@ -38,30 +38,30 @@ function stepDown(value, step, min, optionalStepCount) {
input.type = 'datetime-local';
debug('Invalid value');
-shouldThrow('stepUp("", null, null)');
-shouldThrow('stepDown("", null, null)');
+shouldBeEqualToString('stepUp("", null, null)', '1970-01-01T00:01');
+shouldBeEqualToString('stepDown("", null, null)', '1969-12-31T23:59');
debug('Non-number arguments');
-shouldBe('stepUp("2010-02-10T20:13", null, null, "0")', '"2010-02-10T20:13"');
-shouldBe('stepDown("2010-02-10T20:13", null, null, "0")', '"2010-02-10T20:13"');
-shouldBe('stepUp("2010-02-10T20:13", null, null, "foo")', '"2010-02-10T20:13"');
-shouldBe('stepDown("2010-02-10T20:13", null, null, "foo")', '"2010-02-10T20:13"');
-shouldBe('stepUp("2010-02-10T20:13", null, null, null)', '"2010-02-10T20:13"');
-shouldBe('stepDown("2010-02-10T20:13", null, null, null)', '"2010-02-10T20:13"');
+shouldBeEqualToString('stepUp("2010-02-10T20:13", null, null, "0")', '2010-02-10T20:13');
+shouldBeEqualToString('stepDown("2010-02-10T20:13", null, null, "0")', '2010-02-10T20:13');
+shouldBeEqualToString('stepUp("2010-02-10T20:13", null, null, "foo")', '2010-02-10T20:13');
+shouldBeEqualToString('stepDown("2010-02-10T20:13", null, null, "foo")', '2010-02-10T20:13');
+shouldBeEqualToString('stepUp("2010-02-10T20:13", null, null, null)', '2010-02-10T20:13');
+shouldBeEqualToString('stepDown("2010-02-10T20:13", null, null, null)', '2010-02-10T20:13');
debug('Normal cases');
-shouldBe('stepUp("2010-02-10T20:13", null, null)', '"2010-02-10T20:14"');
-shouldBe('stepDown("2010-02-10T20:13", null, null)', '"2010-02-10T20:12"');
-shouldBe('stepUp("2010-02-10T20:13", null, null, 10)', '"2010-02-10T20:23"');
-shouldBe('stepDown("2010-02-10T20:13", null, null, 11)', '"2010-02-10T20:02"');
-shouldBe('stepUp("1970-01-01T20:13", "4", null, 2)', '"1970-01-01T20:13:08"');
-shouldBe('stepDown("1970-01-01T20:13", "4", null, 3)', '"1970-01-01T20:12:48"');
+shouldBeEqualToString('stepUp("2010-02-10T20:13", null, null)', '2010-02-10T20:14');
+shouldBeEqualToString('stepDown("2010-02-10T20:13", null, null)', '2010-02-10T20:12');
+shouldBeEqualToString('stepUp("2010-02-10T20:13", null, null, 10)', '2010-02-10T20:23');
+shouldBeEqualToString('stepDown("2010-02-10T20:13", null, null, 11)', '2010-02-10T20:02');
+shouldBeEqualToString('stepUp("1970-01-01T20:13", "4", null, 2)', '1970-01-01T20:13:08');
+shouldBeEqualToString('stepDown("1970-01-01T20:13", "4", null, 3)', '1970-01-01T20:12:48');
debug('Step=any');
shouldThrow('stepUp("2010-02-10T20:13", "any", null)');
shouldThrow('stepDown("2010-02-10T20:13", "any", null)');
debug('Overflow/underflow');
-shouldThrow('stepUp("2010-02-10T20:13", "3.40282346e+38", null)');
-shouldThrow('stepDown("2010-02-10T20:13", "3.40282346e+38", null)');
-shouldThrow('stepUp("2010-02-10T20:13", "1", "2010-02-10T20:13")');
-shouldThrow('stepDown("2010-02-10T20:13", "1", "2010-02-10T20:13")');
+shouldBeEqualToString('stepUp("2010-02-10T20:13", "3.40282346e+38", null)', '275760-09-13T00:00:00');
+shouldBeEqualToString('stepDown("2010-02-10T20:13", "3.40282346e+38", null)', '1970-01-01T00:00:00');
+shouldBeEqualToString('stepUp("2010-02-10T20:13", "1", "2010-02-10T20:13")', '2010-02-10T20:13:00');
+shouldBeEqualToString('stepDown("2010-02-10T20:13", "1", "2010-02-10T20:13")', '2010-02-10T20:13:00');
</script>
</body>
</html>

Powered by Google App Engine
This is Rietveld 408576698