LayoutTests/fast/forms/range/range-stepup-stepdown.html - Issue 136783006: Upgrade stepUp()/stepDown() implementation to match spec.

Unified Diff: LayoutTests/fast/forms/range/range-stepup-stepdown.html

Issue 136783006: Upgrade stepUp()/stepDown() implementation to match spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/date/date-stepup-stepdown.html ('K') | « LayoutTests/fast/forms/number/number-stepup-stepdown-expected.txt ('k') | LayoutTests/fast/forms/range/range-stepup-stepdown-expected.txt » ('j') | Source/core/html/forms/InputType.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/forms/range/range-stepup-stepdown.html

diff --git a/LayoutTests/fast/forms/range/range-stepup-stepdown.html b/LayoutTests/fast/forms/range/range-stepup-stepdown.html

index 24642aa5b77bfb689c22c8b8d0e5e76b1cffffba..de7c75737f36cedef756036a12ee4de9e24e6c15 100644

--- a/LayoutTests/fast/forms/range/range-stepup-stepdown.html

+++ b/LayoutTests/fast/forms/range/range-stepup-stepdown.html

@@ -7,7 +7,7 @@

-description('Check stepUp() and stepDown() bahevior for range type.');

+description('Check stepUp() and stepDown() behavior for range type.');

var input;

@@ -109,10 +109,10 @@ shouldBeEqualToString('createInputWithContentAttributes(null, null, "50", "25");

shouldBeEqualToString('createInputWithContentAttributes(null, null, "50", "25"); input.stepUp(1); input.value', '75');

shouldBeEqualToString('createInputWithContentAttributes(null, null, "50", "25"); input.stepUp(1); input.stepDown(1); input.value', '25');

// FIXME: these shouldn't throw according to the spec; commented-out version give its expected outcomes.

keishi 2014/02/05 02:26:36 Do we need to keep this?

sof 2014/02/05 07:48:54 Sorry, an oversight to leave this behind. Removed

-shouldThrow('createInputWithContentAttributes(null, null, "50", "25"); input.stepUp(2); input.stepDown(2);');

-shouldThrow('createInputWithContentAttributes(null, null, "7", "22"); input.stepUp(40);');

-//shouldBeEqualToString('createInputWithContentAttributes(null, null, "50", "25"); input.stepUp(2); input.stepDown(2); input.value', '25');

-//shouldBeEqualToString('createInputWithContentAttributes(null, null, "7", "22"); input.stepUp(40); input.value', '99');

+//shouldThrow('createInputWithContentAttributes(null, null, "50", "25"); input.stepUp(2); input.stepDown(2);');

+//shouldThrow('createInputWithContentAttributes(null, null, "7", "22"); input.stepUp(40);');

+shouldBeEqualToString('createInputWithContentAttributes(null, null, "50", "25"); input.stepUp(2); input.stepDown(2); input.value', '25');

+shouldBeEqualToString('createInputWithContentAttributes(null, null, "7", "22"); input.stepUp(40); input.value', '99');

// Reset 'input' for follow-on tests.

createRangeElement();

@@ -121,28 +121,25 @@ shouldThrow('stepUpExplicitBounds(null, null, "any", "1")');

shouldThrow('stepDownExplicitBounds(null, null, "any", "1")');

debug('Overflow/underflow');

shouldBeEqualToString('stepUpExplicitBounds(null, "100", "1", "99")', '100');

-shouldThrow('stepUpExplicitBounds(null, "100", "1", "100")');

-shouldBeEqualToString('input.value', '100');

-shouldThrow('stepUpExplicitBounds(null, "100", "1", "99", "2")');

-shouldBeEqualToString('input.value', '99');

+shouldBeEqualToString('stepUpExplicitBounds(null, "100", "1", "100")', '100');

+shouldBeEqualToString('stepUpExplicitBounds(null, "100", "1", "99", "2")', '100');

shouldBeEqualToString('stepDownExplicitBounds("0", null, "1", "1")', '0');

-shouldThrow('stepDownExplicitBounds("0", null, "1", "0")');

-shouldBeEqualToString('input.value', '0');

-shouldThrow('stepDownExplicitBounds("0", null, "1", "1", "2")');

-shouldBeEqualToString('input.value', '1');

-shouldThrow('stepDownExplicitBounds(null, null, "3.40282346e+38", "1", "2")');

+shouldBeEqualToString('stepDownExplicitBounds("0", null, "1", "0")', '0');

+shouldBeEqualToString('stepDownExplicitBounds("0", null, "1", "1", "2")', '0');

+shouldBeEqualToString('stepDownExplicitBounds(null, null, "3.40282346e+38", "1", "2")', '0');

shouldBeEqualToString('stepUpExplicitBounds(-100, 0, 1, -1)', '0');

-shouldThrow('stepUpExplicitBounds(null, 0, 1, 0)');

-shouldThrow('stepUpExplicitBounds(-100, 0, 1, -1, 2)');

-shouldBeEqualToString('input.value', '-1');

-shouldThrow('stepUpExplicitBounds(null, null, "3.40282346e+38", "1", "2")');

+shouldBeEqualToString('stepUpExplicitBounds(null, 0, 1, 0)', '0');

+shouldBeEqualToString('stepUpExplicitBounds(-100, 0, 1, -1, 2)', '0');

+shouldBeEqualToString('stepUpExplicitBounds(null, null, "3.40282346e+38", "1", "2")', '0');

debug('stepDown()/stepUp() for stepMismatch values');

shouldBeEqualToString('stepUpExplicitBounds(null, null, 2, 1)', '4');

shouldBeEqualToString('input.stepDown(); input.value', '2');

shouldBeEqualToString('stepUpExplicitBounds(0, null, 10, 9, 9)', '100');

shouldBeEqualToString('stepDownExplicitBounds(0, null, 10, 19)', '10');

debug('value + step is <= max, but rounded result would be > max.');

-shouldThrow('stepUpExplicitBounds(null, 99, 10, 89)');

+shouldBeEqualToString('stepUpExplicitBounds(null, 99, 10, 89)', '90');

+shouldBeEqualToString('stepUpExplicitBounds(null, 99, 10, 89, 21)', '90');

+shouldBeEqualToString('stepUpExplicitBounds(null, 99, 10, 77, 2)', '90');

debug('Huge value and small step');

shouldBeEqualToString('stepUpExplicitBounds(0, 1e38, 1, 1e38, 999999)', '1e+38');

shouldBeEqualToString('stepDownExplicitBounds(0, 1e38, 1, 1e38, 999999)', '1e+38');