Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: Source/core/html/forms/StepRange.cpp

Issue 136783006: Upgrade stepUp()/stepDown() implementation to match spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: applyStep(): add missing EventQueueScope Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/forms/StepRange.h ('k') | Source/core/html/forms/TimeInputType.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 // Decimal's fractional part size is DBL_MAN_DIG-bit. If the current value 154 // Decimal's fractional part size is DBL_MAN_DIG-bit. If the current value
155 // is greater than step*2^DBL_MANT_DIG, the following computation for 155 // is greater than step*2^DBL_MANT_DIG, the following computation for
156 // remainder makes no sense. 156 // remainder makes no sense.
157 DEFINE_STATIC_LOCAL(const Decimal, twoPowerOfDoubleMantissaBits, (Decimal::P ositive, 0, UINT64_C(1) << DBL_MANT_DIG)); 157 DEFINE_STATIC_LOCAL(const Decimal, twoPowerOfDoubleMantissaBits, (Decimal::P ositive, 0, UINT64_C(1) << DBL_MANT_DIG));
158 if (value / twoPowerOfDoubleMantissaBits > m_step) 158 if (value / twoPowerOfDoubleMantissaBits > m_step)
159 return false; 159 return false;
160 // The computation follows HTML5 4.10.7.2.10 `The step attribute' : 160 // The computation follows HTML5 4.10.7.2.10 `The step attribute' :
161 // ... that number subtracted from the step base is not an integral multiple 161 // ... that number subtracted from the step base is not an integral multiple
162 // of the allowed value step, the element is suffering from a step mismatch. 162 // of the allowed value step, the element is suffering from a step mismatch.
163 const Decimal remainder = (value - m_step * (value / m_step).round()).abs(); 163 const Decimal remainder = (value - m_step * (value / m_step).round()).abs();
164 // Accepts erros in lower fractional part which IEEE 754 single-precision 164 // Accepts errors in lower fractional part which IEEE 754 single-precision
165 // can't represent. 165 // can't represent.
166 const Decimal computedAcceptableError = acceptableError(); 166 const Decimal computedAcceptableError = acceptableError();
167 return computedAcceptableError < remainder && remainder < (m_step - computed AcceptableError); 167 return computedAcceptableError < remainder && remainder < (m_step - computed AcceptableError);
168 } 168 }
169 169
170 } // namespace WebCore 170 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/forms/StepRange.h ('k') | Source/core/html/forms/TimeInputType.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698