Source/core/html/forms/InputType.h - Issue 136783006: Upgrade stepUp()/stepDown() implementation to match spec.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/forms/InputType.h

Issue 136783006: Upgrade stepUp()/stepDown() implementation to match spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: applyStep(): add missing EventQueueScope Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/html/forms/DateTimeLocalInputType.cpp ('k') | Source/core/html/forms/InputType.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 * Copyright (C) 2011 Apple Inc. All rights reserved.	3 * Copyright (C) 2011 Apple Inc. All rights reserved.

4 * Copyright (C) 2012 Samsung Electronics. All rights reserved.	4 * Copyright (C) 2012 Samsung Electronics. All rights reserved.

5 *	5 *

6 * Redistribution and use in source and binary forms, with or without	6 * Redistribution and use in source and binary forms, with or without

7 * modification, are permitted provided that the following conditions are	7 * modification, are permitted provided that the following conditions are

8 * met:	8 * met:

9 *	9 *

10 * * Redistributions of source code must retain the above copyright	10 * * Redistributions of source code must retain the above copyright

(...skipping 218 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
229 Decimal parseToNumberOrNaN(const String&) const;	229 Decimal parseToNumberOrNaN(const String&) const;

230 void countUsageIfVisible(UseCounter::Feature) const;	230 void countUsageIfVisible(UseCounter::Feature) const;

231	231

232 // Derive the step base, following the HTML algorithm steps.	232 // Derive the step base, following the HTML algorithm steps.

233 Decimal findStepBase(const Decimal&) const;	233 Decimal findStepBase(const Decimal&) const;

234	234

235 StepRange createStepRange(AnyStepHandling, const Decimal& stepBaseDefault, c onst Decimal& minimumDefault, const Decimal& maximumDefault, const StepRange::St epDescription&) const;	235 StepRange createStepRange(AnyStepHandling, const Decimal& stepBaseDefault, c onst Decimal& minimumDefault, const Decimal& maximumDefault, const StepRange::St epDescription&) const;

236	236

237 private:	237 private:

238 // Helper for stepUp()/stepDown(). Adds step value * count to the current va lue.	238 // Helper for stepUp()/stepDown(). Adds step value * count to the current va lue.

239 void applyStep(int count, AnyStepHandling, TextFieldEventBehavior, Exception State&);	239 void applyStep(const Decimal&, int count, AnyStepHandling, TextFieldEventBeh avior, ExceptionState&);

240 };	240 };

241	241

242 } // namespace WebCore	242 } // namespace WebCore

243 #endif	243 #endif

OLD	NEW