Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 136773002: Android: upstream few more jni_generator changes. (Closed)

Created:
6 years, 11 months ago by bulach
Modified:
6 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Android: upstream few more jni_generator changes. - always use "native" prefix for native calls. - parametrize javap and cpp BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245209

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M base/android/jni_generator/jni_generator.py View 8 chunks +11 lines, -7 lines 0 comments Download
M base/android/jni_generator/jni_generator_tests.py View 4 chunks +6 lines, -4 lines 2 comments Download
M base/android/jni_generator/testEagerCalledByNativesOption.golden View 1 chunk +2 lines, -2 lines 0 comments Download
M base/android/jni_generator/testJNIInitNativeNameOption.golden View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bulach
ptal
6 years, 11 months ago (2014-01-13 14:51:05 UTC) #1
dawalker
On 2014/01/13 14:51:05, bulach wrote: > ptal LGTM
6 years, 11 months ago (2014-01-13 21:31:08 UTC) #2
nadiapayet
LGTM
6 years, 11 months ago (2014-01-13 21:59:36 UTC) #3
rmcilroy
lgtm One minor nit, but feel free to ignore since this only affects the test. ...
6 years, 11 months ago (2014-01-14 10:13:52 UTC) #4
bulach
thanks ross! clarification below, CQing.. https://codereview.chromium.org/136773002/diff/1/base/android/jni_generator/jni_generator_tests.py File base/android/jni_generator/jni_generator_tests.py (right): https://codereview.chromium.org/136773002/diff/1/base/android/jni_generator/jni_generator_tests.py#newcode974 base/android/jni_generator/jni_generator_tests.py:974: private static native boolean ...
6 years, 11 months ago (2014-01-16 11:03:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/136773002/1
6 years, 11 months ago (2014-01-16 11:04:15 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 16:08:18 UTC) #7
Message was sent while issue was closed.
Change committed as 245209

Powered by Google App Engine
This is Rietveld 408576698