Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 1367713002: PdfMetafileSkia: Embed Creator, CreationDate, and ModDate in PDF. (Closed)

Created:
5 years, 3 months ago by hal.canary
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PdfMetafileSkia: Embed Creator, CreationDate, and ModDate in PDF. Committed: https://crrev.com/67ce00b8655fc75238c673154b5b100cf40740fd Cr-Commit-Position: refs/heads/master@{#351011}

Patch Set 1 #

Patch Set 2 : Use base::Time::Now(), not SkTime::GetDateTime() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M printing/pdf_metafile_skia.cc View 1 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
hal.canary
please take a look going forward, more metadata can be added, if that's the direction ...
5 years, 3 months ago (2015-09-23 20:59:54 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 3 months ago (2015-09-23 21:13:19 UTC) #3
tomhudson
lgtm
5 years, 2 months ago (2015-09-25 21:01:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367713002/1
5 years, 2 months ago (2015-09-25 21:03:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/102672)
5 years, 2 months ago (2015-09-25 21:25:14 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367713002/20001
5 years, 2 months ago (2015-09-27 17:52:19 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-27 18:46:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367713002/20001
5 years, 2 months ago (2015-09-27 21:55:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-27 22:00:04 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/67ce00b8655fc75238c673154b5b100cf40740fd Cr-Commit-Position: refs/heads/master@{#351011}
5 years, 2 months ago (2015-09-27 22:00:49 UTC) #17
hal.canary
5 years, 2 months ago (2015-09-28 00:55:12 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1367393002/ by halcanary@google.com.

The reason for reverting is: buildbot warning in Chromium Memory FYI on Linux
ChromeOS MSan Tests, revision .

Powered by Google App Engine
This is Rietveld 408576698