Make 2D canvas smarter about chosing whether or not to use GPU acceleration

Make 2D canvas smarter about chosing whether or not to use GPU acceleration

The CL takes advantage of the fact that canvas rendering is deferred
to defer the decision of whether or not a canvas should be
GPU-accelerated. The decision is made based on the conditions
under which a canvas is flushed for the first time. For example,
if the purpose of the first flush is to perform a readback, then
GPU-acceleration will be disabled for the canvas in order to avoid
reading GPU memory into RAM, which is known to be a slow path.

BUG=265849
TBR=senorblanco@chromium.org, kbr@chromium.org
NOTRY=true

Committed: https://crrev.com/9ac9c385c8f55f826c42e1f3a56cf66600b9e934
Cr-Commit-Position: refs/heads/master@{#350655}

[Justin Novosad, 2015-09-23 20:40:17]

using TBR because l-g-t-m were already obtained here before the blink-chromium
merge: https://codereview.chromium.org/1307143005/

[Justin Novosad, 2015-09-23 20:40:23]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2015-09-23 20:42:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1367683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1367683002/1

[commit-bot: I haz the power, 2015-09-24 01:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 01:05:35]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Russell (switch to Gerrit), 2015-09-24 01:37:37]

On 2015/09/24 01:05:35, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Filed http://crbug.com/535383 about this failure.

[Justin Novosad, 2015-09-24 18:16:42]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2015-09-24 18:17:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1367683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1367683002/20001

[commit-bot: I haz the power, 2015-09-24 20:10:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 20:10:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Justin Novosad, 2015-09-24 20:34:53]

The CQ bit was checked by junov@chromium.org

[commit-bot: I haz the power, 2015-09-24 20:36:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1367683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1367683002/20001

[commit-bot: I haz the power, 2015-09-24 20:44:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-24 20:45:11]

Patchset 2 (id:??) landed as
https://crrev.com/9ac9c385c8f55f826c42e1f3a56cf66600b9e934
Cr-Commit-Position: refs/heads/master@{#350655}

[Ken Russell (switch to Gerrit), 2015-09-24 21:17:39]

On 2015/09/24 20:10:08, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Justin, that tryjob failure failed an assertion in the Canvas code:

ASSERTION FAILED: releasedMailboxInfo == firstMailbox
../../third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp(518) :
virtual void blink::Canvas2DLayerBridge::mailboxReleased(const
blink::WebExternalTextureMailbox &, bool)
1   0x4d0275a
2   0x4d027d2
3   0x60f1b07
4   0x60a5a58
5   0x61042d7
6   0x614516e
7   0x614a853
8   0x614a7ae
9   0x1a4a093
10  0x4b6334e
11  0x4b61b53
12  0x1a4a093
13  0x19eeb4b
14  0x19eee49
15  0x19ef01d
16  0x19f062d
17  0x19ee6ae
18  0x1a03925
19  0x19ed930
20  0x6c50ba2
21  0x6a6dc25
22  0x6a6ea70
23  0x6a6d850
24  0x5abb574
25  0x1992cea
26  0x10b4e99
27  0x7fa196be476d __libc_start_main
28  0x5bc909
Received signal 11 SEGV_MAPERR 0000fbadbeef
#0 0x0000019d3ab5 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7fa1984cdcb0 <unknown>
#2 0x000006571efd blink::Canvas2DLayerBridge::mailboxReleased()
#3 0x000004d0275a cc_blink::WebExternalTextureLayerImpl::DidReleaseMailbox()
#4 0x000004d027d2
_ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIPFvNS_7WeakPtrIN8cc_blink27WebExternalTextureLayerImplEEERKN5blink25WebExternalTextureMailboxEPNS7_21WebExternalBitmapImplEjbEEESG_NS0_8TypeListIJS9_SB_SF_EEEEENSJ_IJNS0_12UnwrapTraitsIS9_EENSM_ISB_EENSM_ISF_EEEEENS0_12InvokeHelperILb0EvSI_NSJ_IJRKS9_SD_RKSF_RKjRKbEEEEEFvSX_SZ_EE3RunEPNS0_13BindStateBaseESX_SZ_
#5 0x0000060f1b07 cc::SingleReleaseCallback::Run()
#6 0x0000060a5a58 cc::TextureLayer::TextureMailboxHolder::InternalRelease()
#7 0x0000061042d7 cc::BlockingTaskRunner::SetCapture()
#8 0x00000614516e cc::ThreadProxy::BeginMainFrame()
#9 0x00000614a853
_ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIMN2cc11ThreadProxyEFv10scoped_ptrINS4_28BeginMainFrameAndCommitStateENS_14DefaultDeleterIS6_EEEEEENS0_8TypeListIJRKNS_7WeakPtrIS4_EES9_EEEE8MakeItSoESC_SH_S9_
#10 0x00000614a7ae
_ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN2cc11ThreadProxyEFv10scoped_ptrINS7_28BeginMainFrameAndCommitStateENS_14DefaultDeleterIS9_EEEEEEFvPS7_SC_ENS0_8TypeListIJNS_7WeakPtrIS7_EENS0_13PassedWrapperISC_EEEEEEENSI_IJNS0_12UnwrapTraitsISK_EENSP_ISM_EEEEENS0_12InvokeHelperILb1EvSF_NSI_IJRKSK_SC_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#11 0x000001a4a093 base::debug::TaskAnnotator::RunTask()
#12 0x000004b6334e scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#13 0x000004b61b53 scheduler::TaskQueueManager::DoWork()
#14 0x000001a4a093 base::debug::TaskAnnotator::RunTask()
#15 0x0000019eeb4b base::MessageLoop::RunTask()
#16 0x0000019eee49 base::MessageLoop::DeferOrRunPendingTask()
#17 0x0000019ef01d base::MessageLoop::DoWork()
#18 0x0000019f062d base::MessagePumpDefault::Run()
#19 0x0000019ee6ae base::MessageLoop::RunHandler()
#20 0x000001a03925 base::RunLoop::Run()
#21 0x0000019ed930 base::MessageLoop::Run()
#22 0x000006c50ba2 content::RendererMain()
#23 0x000006a6dc25 content::RunZygote()
#24 0x000006a6ea70 content::ContentMainRunnerImpl::Run()
#25 0x000006a6d850 content::ContentMain()
#26 0x000005abb574 content::LaunchTests()
#27 0x000001992cea LaunchChromeTests()
#28 0x0000010b4e99 main
#29 0x7fa196be476d __libc_start_main
#30 0x0000005bc909 <unknown>
  r8: 00007fa19b7388c0  r9: 00000000004002d0 r10: 00000000071ab45a r11:
0000000000000000
 r12: 000000000000000e r13: 000032a6cb4fd4b0 r14: 000009265ff92410 r15:
0000000000000580
  di: 0000000000000000  si: 0000000000000000  bp: 0000000000000000  bx:
0000000000000010
  dx: 00007fa196f7ca80  ax: 00000000fbadbeef  cx: ffffffffffffffff  sp:
00007ffcffab0c30
  ip: 0000000006571efd efl: 0000000000010202 cgf: 0000000000000033 erf:
0000000000000006
 trp: 000000000000000e msk: 0000000000000000 cr2: 00000000fbadbeef
[end of stack trace]


Is it possible that this CL introduced a flaky test failure?

[Justin Novosad, 2015-09-24 21:36:26]

I was sure I was in the clear when I saw the same tests fail with and without
the patch.  What is going on!

[Justin Novosad, 2015-09-24 21:37:29]

Reverting.

[Justin Novosad, 2015-09-24 21:38:03]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1361043003/ by junov@chromium.org.

The reason for reverting is: Patch has test failures.