Expose all reusable task manager view code so it can be used by Mac

chrome/browser/ui/task_manager/task_manager_columns.h

Index: chrome/browser/ui/task_manager/task_manager_columns.h
diff --git a/chrome/browser/ui/task_manager/task_manager_columns.h b/chrome/browser/ui/task_manager/task_manager_columns.h
new file mode 100644
index 0000000000000000000000000000000000000000..1885067972ace1902a4d8ce08a10a00d4dac0f27
--- /dev/null
+++ b/chrome/browser/ui/task_manager/task_manager_columns.h
@@ -0,0 +1,59 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_TASK_MANAGER_TASK_MANAGER_COLUMNS_H_
+#define CHROME_BROWSER_UI_TASK_MANAGER_TASK_MANAGER_COLUMNS_H_
+
+#include "base/macros.h"

[Lei Zhang, 2015/09/24 05:33:57]

nit: no macros here

[afakhry, 2015/09/25 16:39:49]

Done.

+#include "ui/base/models/table_model.h"
+
+namespace task_management {
+
+// A collection of data to be used in the construction of a task manager table
+// column.
+struct TableColumnData {
+  // The generated ID of the column. These can change from one build to another.
+  // Their values are controlled by the generation from generated_resources.grd.
+  int id;
+
+  // The alignment of the text displayed in this column.
+  ui::TableColumn::Alignment align;
+
+  // |width| and |percent| used to define the size of the column. See
+  // ui::TableColumn::width and ui::TableColumn::percent for details.
+  int width;
+  float percent;
+
+  // min and max widths used for Mac's implementation and are ignored on Views.
+  // If |max_width| is -1, a value of 1.5 * |min_width| will be used.
+  int min_width;
+  int max_width;
+
+  // Is the column sortable.
+  bool sortable;
+
+  // Is the initial sort order ascending?
+  bool initial_sort_is_ascending;
+
+  // The default visibility of this column at startup of the table if no
+  // visibility is stored for it in the prefs.
+  bool default_visibility;
+};
+
+// The task manager table columns and their properties.
+extern const TableColumnData kColumns[];
+extern const size_t kColumnsSize;
+
+// Session Restore Keys.
+extern const char kSortColumnIdKey[];
+extern const char kSortIsAscendingKey[];
+
+// Returns the |column_id| as a string value to be used as keys in the user
+// preferences.
+std::string GetColumnIdAsString(int column_id);
+
+}  // namespace task_management
+

[Lei Zhang, 2015/09/24 05:33:57]

nit: extra blank line

[afakhry, 2015/09/25 16:39:49]

Done.

+
+#endif  // CHROME_BROWSER_UI_TASK_MANAGER_TASK_MANAGER_COLUMNS_H_