Expose all reusable task manager view code so it can be used by Mac

Expose all reusable task manager view code so it can be used by Mac

A lot of the code used in NewTaskManagerView is reusable for the Mac
implementation. This CL extarcts this code and makes it in common place
accessible by both Aura Views and Mac's cocoa.

BUG=530309
TEST=browser_tests --gtest_filter=NewTaskManagerViewTest.*

Committed: https://crrev.com/f857def5e3bbce342de37d7fa79f4d5487f03fbb
Cr-Commit-Position: refs/heads/master@{#350904}

[afakhry, 2015-09-23 23:50:46]

afakhry@chromium.org changed reviewers:
+ thestig@chromium.org

[afakhry, 2015-09-23 23:50:47]

thestig@chromium.org: Can you please review this CL?
Context: In order to migrate the task manager on Mac to use the new
implementation, we had to extract all the re-usable code in the aura views
implementation so that we avoid code duplication.

[Lei Zhang, 2015-09-24 05:33:58]

Mostly good. You should add a chrome/browser/ui/task_manager/DEPS file with
rules to prevent views/mac specific #includes.

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
File chrome/browser/ui/task_manager/task_manager_columns.h (right):

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
chrome/browser/ui/task_manager/task_manager_columns.h:8: #include
"base/macros.h"
nit: no macros here

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
chrome/browser/ui/task_manager/task_manager_columns.h:57: 
nit: extra blank line

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
File chrome/browser/ui/task_manager/task_manager_table_model.h (right):

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
chrome/browser/ui/task_manager/task_manager_table_model.h:57:
TaskManagerTableModel(int64 refresh_flags, TableViewDelegate* delegate);
int64_t (see comments in base/basictypes.h) Also in task_manager_table_model.cc.

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
chrome/browser/ui/task_manager/task_manager_table_model.h:90: 
nit: extra blank line

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/views/new...
File chrome/browser/ui/views/new_task_manager_view.cc (right):

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/views/new...
chrome/browser/ui/views/new_task_manager_view.cc:69: class
NewTaskManagerView::ViewsTableDelegate : public TableViewDelegate {
Can NewTaskManagerView itself implement the TableViewDelegate interface, instead
of having a separate class?

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/views/new...
File chrome/browser/ui/views/new_task_manager_view_browsertest.cc (right):

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/views/new...
chrome/browser/ui/views/new_task_manager_view_browsertest.cc:5: #include
<wchar.h>
what's this for?

[afakhry, 2015-09-25 16:39:50]

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
File chrome/browser/ui/task_manager/task_manager_columns.h (right):

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
chrome/browser/ui/task_manager/task_manager_columns.h:8: #include
"base/macros.h"
On 2015/09/24 05:33:57, Lei Zhang wrote:
> nit: no macros here

Done.

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
chrome/browser/ui/task_manager/task_manager_columns.h:57: 
On 2015/09/24 05:33:57, Lei Zhang wrote:
> nit: extra blank line

Done.

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
File chrome/browser/ui/task_manager/task_manager_table_model.h (right):

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
chrome/browser/ui/task_manager/task_manager_table_model.h:57:
TaskManagerTableModel(int64 refresh_flags, TableViewDelegate* delegate);
On 2015/09/24 05:33:58, Lei Zhang wrote:
> int64_t (see comments in base/basictypes.h) Also in
task_manager_table_model.cc.

Done here! Though I should send a follow-up CL after this to change all the
int64's under c/b/task_management to int64_t's.

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/task_mana...
chrome/browser/ui/task_manager/task_manager_table_model.h:90: 
On 2015/09/24 05:33:58, Lei Zhang wrote:
> nit: extra blank line

Done.

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/views/new...
File chrome/browser/ui/views/new_task_manager_view.cc (right):

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/views/new...
chrome/browser/ui/views/new_task_manager_view.cc:69: class
NewTaskManagerView::ViewsTableDelegate : public TableViewDelegate {
On 2015/09/24 05:33:58, Lei Zhang wrote:
> Can NewTaskManagerView itself implement the TableViewDelegate interface,
instead
> of having a separate class?

Done.

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/views/new...
File chrome/browser/ui/views/new_task_manager_view_browsertest.cc (right):

https://codereview.chromium.org/1367673003/diff/1/chrome/browser/ui/views/new...
chrome/browser/ui/views/new_task_manager_view_browsertest.cc:5: #include
<wchar.h>
On 2015/09/24 05:33:58, Lei Zhang wrote:
> what's this for?

Not sure how this ended up here! Probably eclipse added it for me when I pressed
Ctrl+Shift+N to add a missing include.
Removed.

[Lei Zhang, 2015-09-25 18:02:51]

I had a top level comment about adding a DEPS file. ^^ Thoughts?

[Lei Zhang, 2015-09-25 18:05:09]

Otherwise LGTM

[afakhry, 2015-09-25 18:24:25]

Oh sorry, I missed that comment. Please take a look at the DEPS file I added. Is
that what you meant?

[Lei Zhang, 2015-09-25 18:47:00]

lgtm

https://codereview.chromium.org/1367673003/diff/40001/chrome/browser/ui/task_...
File chrome/browser/ui/task_manager/DEPS (right):

https://codereview.chromium.org/1367673003/diff/40001/chrome/browser/ui/task_...
chrome/browser/ui/task_manager/DEPS:2: "-chrome/browser/ui/cocoa",
Also "-chrome/browser/ui/views"

[afakhry, 2015-09-25 19:47:54]

https://codereview.chromium.org/1367673003/diff/40001/chrome/browser/ui/task_...
File chrome/browser/ui/task_manager/DEPS (right):

https://codereview.chromium.org/1367673003/diff/40001/chrome/browser/ui/task_...
chrome/browser/ui/task_manager/DEPS:2: "-chrome/browser/ui/cocoa",
On 2015/09/25 18:47:00, Lei Zhang wrote:
> Also "-chrome/browser/ui/views"

Done.

[afakhry, 2015-09-25 19:48:07]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2015-09-25 19:48:07]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1367673003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-09-25 19:49:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1367673003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1367673003/60001

[commit-bot: I haz the power, 2015-09-25 20:47:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-25 20:48:09]

Patchset 4 (id:??) landed as
https://crrev.com/f857def5e3bbce342de37d7fa79f4d5487f03fbb
Cr-Commit-Position: refs/heads/master@{#350904}