Issue 1367633005: Cleanup some fx_codec_fax.cpp code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1367633005: Cleanup some fx_codec_fax.cpp code. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cleanup some fx_codec_fax.cpp code. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/39cd934a4705f69c30e1bbf13eab347f66999020

Patch Set 1 : Sanitizer func decl, move code into anonymous namespace #

Patch Set 2 : fix boolean silliness #

Total comments: 1

Patch Set 3 : rebase #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+216 lines, -203 lines)			Patch
M	core/include/fxcodec/fx_codec.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_fax.cpp	View	1	22 chunks	+205 lines, -191 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_Define.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_GrdProc.cpp	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Tom Sepez

lgtm https://codereview.chromium.org/1367633005/diff/20001/core/src/fxcodec/codec/fx_codec_fax.cpp File core/src/fxcodec/codec/fx_codec_fax.cpp (left): https://codereview.chromium.org/1367633005/diff/20001/core/src/fxcodec/codec/fx_codec_fax.cpp#oldcode77 core/src/fxcodec/codec/fx_codec_fax.cpp:77: if (a0color) { splendid. It's that "sadly not ...

5 years, 2 months ago (2015-09-28 17:35:34 UTC) #3

Lei Zhang

5 years, 2 months ago (2015-09-28 18:52:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
39cd934a4705f69c30e1bbf13eab347f66999020 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages