Issue 1367633004: Merge to XFA: Fix a couple potential file handle leaks in pdfium_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1367633004: Merge to XFA: Fix a couple potential file handle leaks in pdfium_test. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Fix a couple potential file handle leaks in pdfium_test. Fix lint issues / git cl format. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1357423006 . (cherry picked from commit 155345e2c47188fa65da1603b7f06c986707bb69) Committed: https://pdfium.googlesource.com/pdfium/+/5377ebf967ea860eec4b3cfa3877ed30b84509dc

Patch Set 2 : more nits #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -31 lines)			Patch
	M	samples/pdfium_test.cc	View	1	9 chunks	+33 lines, -31 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

PTA(Q)L ? https://codereview.chromium.org/1367633004/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/1367633004/diff/1/samples/pdfium_test.cc#newcode472 samples/pdfium_test.cc:472: if (!doc) { We conflicted here. This ...

5 years, 2 months ago (2015-09-23 21:48:29 UTC) #1

Tom Sepez

(Q) LGTM https://codereview.chromium.org/1367633004/diff/1/samples/pdfium_test.cc File samples/pdfium_test.cc (right): https://codereview.chromium.org/1367633004/diff/1/samples/pdfium_test.cc#newcode472 samples/pdfium_test.cc:472: if (!doc) { On 2015/09/23 21:48:28, Lei ...

5 years, 2 months ago (2015-09-23 21:52:12 UTC) #2

Lei Zhang

5 years, 2 months ago (2015-09-23 21:53:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5377ebf967ea860eec4b3cfa3877ed30b84509dc (presubmit successful).

Expand Messages | Collapse Messages

Issue 1367633004: Merge to XFA: Fix a couple potential file handle leaks in pdfium_test. (Closed)

Description

Patch Set 1 #

Patch Set 2 : more nits #

Messages