Fix User->image() without ImageSkia representation after login

Fix User->image() without ImageSkia representation after login

If the user chose an external avatar image (a downloaded file or a webcam
shot), the avatar image would remain invalid until the external image has
been loaded and decoded. This led to a race on login where the image may
be accessed before the load has completed. The CL fixes this by
substituting a stub image while the load is in progress.

BUG=331365
TEST=Manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244536

[bartfab (slow), 2014-01-13 15:27:40]

Hi Nikita,

Could you please review?

[Nikita (slow), 2014-01-13 16:04:13]

lgtm

I think this fix a bug that we saw rarely when a red square (incorrect bitmap)
was shown.

[bartfab (slow), 2014-01-13 16:07:17]

On 2014/01/13 16:04:13, Nikita Kostylev wrote:
> lgtm
> 
> I think this fix a bug that we saw rarely when a red square (incorrect bitmap)
> was shown.

I saw the green bottle with bubbles instead. I guess in both cases, zombie
bitmaps were showing up from somewhere random in memory.

[commit-bot: I haz the power, 2014-01-13 16:08:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/136763003/1

[commit-bot: I haz the power, 2014-01-13 18:10:55]

Change committed as 244536