Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1367623002: GM for http://skbug.com/4374 (Closed)

Created:
5 years, 3 months ago by hal.canary
Modified:
5 years, 3 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2015-09-23 (Wednesday) 15:36:51 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A gm/draw_bitmap_rect_skbug4374.cpp View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hal.canary
please rubberstamp
5 years, 3 months ago (2015-09-23 19:19:04 UTC) #2
tomhudson
Please fix filename to be 4374 instead of 4734. Otherwise ready to go.
5 years, 3 months ago (2015-09-23 19:26:30 UTC) #3
hal.canary
On 2015/09/23 19:26:30, tomhudson wrote: > Please fix filename to be 4374 instead of 4734. ...
5 years, 3 months ago (2015-09-23 19:41:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367623002/20001
5 years, 3 months ago (2015-09-23 19:41:35 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-23 19:41:37 UTC) #7
tomhudson
lgtm
5 years, 3 months ago (2015-09-23 19:44:45 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 19:46:27 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5cd406f0f6dfe74f052cf8f79bd200cffaed65b8

Powered by Google App Engine
This is Rietveld 408576698