Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 136753016: remove (unused by chrome) SkDeferredCanvas(device) factory signature (Closed)

Created:
6 years, 10 months ago by reed1
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

remove (unused by chrome) SkDeferredCanvas(device) factory signature BUG=skia: R=junov@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=13302

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -95 lines) Patch
M bench/DeferredCanvasBench.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 3 chunks +0 lines, -17 lines 0 comments Download
M tests/CanvasTest.cpp View 3 chunks +10 lines, -4 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 12 chunks +80 lines, -73 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
still looking at benchmark.cpp, which is a little too SkDevice-crazy
6 years, 10 months ago (2014-02-03 20:37:47 UTC) #1
Justin Novosad
https://codereview.chromium.org/136753016/diff/1/tests/DeferredCanvasTest.cpp File tests/DeferredCanvasTest.cpp (right): https://codereview.chromium.org/136753016/diff/1/tests/DeferredCanvasTest.cpp#newcode471 tests/DeferredCanvasTest.cpp:471: #if 0 // TODO -- need a surface-oriented way ...
6 years, 10 months ago (2014-02-03 21:33:47 UTC) #2
reed1
ptal https://codereview.chromium.org/136753016/diff/1/tests/DeferredCanvasTest.cpp File tests/DeferredCanvasTest.cpp (right): https://codereview.chromium.org/136753016/diff/1/tests/DeferredCanvasTest.cpp#newcode471 tests/DeferredCanvasTest.cpp:471: #if 0 // TODO -- need a surface-oriented ...
6 years, 10 months ago (2014-02-03 21:52:39 UTC) #3
Justin Novosad
lgtm
6 years, 10 months ago (2014-02-03 22:28:09 UTC) #4
reed1
6 years, 10 months ago (2014-02-04 15:34:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r13302 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698