Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 136753015: aw: Move clearView implementaiton to native (Closed)

Created:
6 years, 10 months ago by boliu
Modified:
6 years, 10 months ago
Reviewers:
Kristian Monsen
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

aw: Move clearView implementaiton to native Also untangle clearView implementation from picture listener enabled. Add some comments and removed some error logs. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248595

Patch Set 1 #

Patch Set 2 : invalidate to native too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -26 lines) Patch
M android_webview/browser/browser_view_renderer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/browser/in_process_view_renderer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M android_webview/browser/in_process_view_renderer.cc View 1 7 chunks +31 lines, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 1 6 chunks +7 lines, -24 lines 0 comments Download
M android_webview/native/aw_contents.h View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
boliu
A clean up for a feature you added in the olden days :)
6 years, 10 months ago (2014-02-03 19:37:38 UTC) #1
Kristian Monsen
lgtm as long as the tests are still passing
6 years, 10 months ago (2014-02-03 19:46:43 UTC) #2
boliu
On 2014/02/03 19:46:43, Kristian Monsen wrote: > lgtm as long as the tests are still ...
6 years, 10 months ago (2014-02-03 19:52:40 UTC) #3
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 10 months ago (2014-02-03 19:52:49 UTC) #4
Kristian Monsen
On 2014/02/03 19:52:40, boliu wrote: > On 2014/02/03 19:46:43, Kristian Monsen wrote: > > lgtm ...
6 years, 10 months ago (2014-02-03 19:53:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/136753015/30001
6 years, 10 months ago (2014-02-03 19:54:12 UTC) #6
boliu
On 2014/02/03 19:53:32, Kristian Monsen wrote: > On 2014/02/03 19:52:40, boliu wrote: > > On ...
6 years, 10 months ago (2014-02-03 19:57:06 UTC) #7
Kristian Monsen
On 2014/02/03 19:57:06, boliu wrote: > On 2014/02/03 19:53:32, Kristian Monsen wrote: > > On ...
6 years, 10 months ago (2014-02-03 19:59:19 UTC) #8
commit-bot: I haz the power
Change committed as 248595
6 years, 10 months ago (2014-02-03 22:28:34 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 22:28:39 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 22:28:45 UTC) #11
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698