Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: runtime/vm/intermediate_language.h

Issue 136753012: Refactor unboxed fields in preparation of reusable SIMD boxes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index 516a1829978a74551976a841004b23d6a413fe52..09dd3d0251ab83a71a0220605f8401fd0317ac2e 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -3509,11 +3509,7 @@ class StoreInstanceFieldInstr : public TemplateDefinition<2> {
bool IsPotentialUnboxedStore() const;
- virtual Representation RequiredInputRepresentation(intptr_t index) const {
- ASSERT((index == 0) || (index == 1));
- if ((index == 1) && IsUnboxedStore()) return kUnboxedDouble;
- return kTagged;
- }
+ virtual Representation RequiredInputRepresentation(intptr_t index) const;
private:
friend class FlowGraphOptimizer; // For ASSERT(initialization_).
@@ -4260,9 +4256,7 @@ class LoadFieldInstr : public TemplateDefinition<1> {
const Field* field() const { return field_; }
void set_field(const Field* field) { field_ = field; }
- virtual Representation representation() const {
- return IsUnboxedLoad() ? kUnboxedDouble : kTagged;
- }
+ virtual Representation representation() const;
bool IsUnboxedLoad() const;
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698