Issue 136753005: [telemetry] convert bitmaptools to use gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136753005: [telemetry] convert bitmaptools to use gyp (Closed)

Created:
6 years, 11 months ago by szym

Modified:
6 years, 11 months ago

Reviewers:
scottmg

CC:
chromium-reviews, chrome-speed-team+watch_google.com, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] convert bitmaptools to use gyp BUG=333606

Patch Set 1 #

Patch Set 2 : use gyp #

Patch Set 3 : another try for windows #

Patch Set 4 : another attempt #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -42 lines)			Patch
M	tools/telemetry/telemetry.gyp	View	1 2 3	1 chunk	+17 lines, -29 lines	0 comments	Download
M	tools/telemetry/telemetry/core/bitmaptools/__init__.py	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/bitmaptools/bitmaptools.cc	View	1 2 3	1 chunk	+7 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/core/build_extension.py	View	1 2 3	4 chunks	+31 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scottmg

I'm not exactly sure what you were asking about in the other bug, but perhaps ...

6 years, 11 months ago (2014-01-15 06:28:59 UTC) #1

szym

6 years, 11 months ago (2014-01-15 07:42:14 UTC) #2

Unfortunately, the MSVC path in distutils is dramatically different from
UNIX-style. It does not seem that the flags used for MSVC depend on much,
so I could probably find a fixed set of flags that would work.

The incompatibility of compilers (VS2008 vs. VS2010e) concerns me, but so
far it was not a problem.

I'll try the external tool with pipe interface. I think it should work.

On Wed, Jan 15, 2014 at 1:28 AM, <scottmg@chromium.org> wrote:

> I'm not exactly sure what you were asking about in the other bug, but
> perhaps
> https://code.google.com/p/gyp/wiki/InputFormatReference#
> Pathname_Relativization
> is helpful?
>
> This seems like it won't help for Windows as it's still relying on finding
> a
> system install of VS inside this script?
>
> https://codereview.chromium.org/136753005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages