Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1367523005: X87: [ic] Introduce BOOLEAN state for CompareIC. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ic] Introduce BOOLEAN state for CompareIC. port 10c5f2e85ef92b7ca002ef95e406d5dc4f0c410b original commit message: Slow path for relational comparison of boolean primitive values now goes through the runtime, which made the slow path even slower than it already was. So in order to repair the regression, we just track boolean feedback for comparisons and use that to generate decent code in Crankshaft (not the best possible code, but good enough for Crankshaft; TurboFan will be able to do better on that). BUG= Committed: https://crrev.com/28de5bf8fbd55646ee9f0594fee57cb4b64898f5 Cr-Commit-Position: refs/heads/master@{#30903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal
5 years, 3 months ago (2015-09-24 08:22:03 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-24 08:30:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367523005/1
5 years, 3 months ago (2015-09-24 08:30:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 08:53:27 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 08:53:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28de5bf8fbd55646ee9f0594fee57cb4b64898f5
Cr-Commit-Position: refs/heads/master@{#30903}

Powered by Google App Engine
This is Rietveld 408576698