Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1367523003: EDK: mostly style fix: change TestIOThread::Mode to an enum class. (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 3 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: mostly style fix: change TestIOThread::Mode to an enum class. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/50b0d83995acda5f4cd4d933a14cac693a57cecc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M mojo/edk/embedder/embedder_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/channel_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/test/test_io_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/test/test_io_thread.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 3 months ago (2015-09-23 19:49:35 UTC) #1
vardhan
lgtm
5 years, 3 months ago (2015-09-23 23:37:25 UTC) #2
viettrungluu
5 years, 3 months ago (2015-09-23 23:38:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
50b0d83995acda5f4cd4d933a14cac693a57cecc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698