third_party/WebKit/Source/core/dom/NodeList.h - Issue 1367523002: [dom] support iterable<> NodeList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/NodeList.h

Issue 1367523002: [dom] support iterable<> NodeList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actual on the left, expected on the right Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/NodeList.h

diff --git a/third_party/WebKit/Source/core/dom/NodeList.h b/third_party/WebKit/Source/core/dom/NodeList.h

index ab50dd22ed1e7ad25e58e40fc868a9f9d845d935..17be3f13f427d220f2eea16451dd7e6d33f68f23 100644

--- a/third_party/WebKit/Source/core/dom/NodeList.h

+++ b/third_party/WebKit/Source/core/dom/NodeList.h

@@ -24,6 +24,7 @@

#ifndef NodeList_h

#define NodeList_h

+#include "bindings/core/v8/Iterable.h"

#include "bindings/core/v8/ScriptWrappable.h"

#include "core/CoreExport.h"

#include "wtf/RefCounted.h"

@@ -32,7 +33,7 @@ namespace blink {

class Node;

-class CORE_EXPORT NodeList : public RefCountedWillBeGarbageCollectedFinalized<NodeList>, public ScriptWrappable {

+class CORE_EXPORT NodeList : public RefCountedWillBeGarbageCollectedFinalized<NodeList>, public ScriptWrappable, public ValueIterable<Node *> {

DEFINE_WRAPPERTYPEINFO();

public:

virtual ~NodeList() { }

@@ -51,6 +52,9 @@ public:

protected:

NodeList() { }

+private:

+ IterationSource* startIteration(ScriptState*, ExceptionState&) override;

};

} // namespace blink