Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1367453002: Re-enabling 720p WebRTC video quality test. (Closed)

Created:
5 years, 3 months ago by phoglund_chromium
Modified:
5 years, 2 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enabling 720p WebRTC video quality test. Closing the local streams seems to solve the buffer thrashing that's going on while gathering frames; this should stop the test from timing out on Windows. BUG=532918, webrtc:4986 Committed: https://crrev.com/5743af3d0c098fa86f587269519e226ecce185e4 Cr-Commit-Position: refs/heads/master@{#351034}

Patch Set 1 #

Patch Set 2 : Post-blink merge update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
phoglund_chromium
5 years, 3 months ago (2015-09-23 10:30:24 UTC) #2
phoglund_chromium
5 years, 2 months ago (2015-09-25 10:51:15 UTC) #4
perkj_chrome
On 2015/09/25 10:51:15, phoglund_chrome wrote: lgtm
5 years, 2 months ago (2015-09-28 07:37:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367453002/20001
5 years, 2 months ago (2015-09-28 07:45:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 08:18:19 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5743af3d0c098fa86f587269519e226ecce185e4 Cr-Commit-Position: refs/heads/master@{#351034}
5 years, 2 months ago (2015-09-28 08:19:05 UTC) #9
phoglund_chromium
5 years, 2 months ago (2015-09-28 12:10:03 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1372923002/ by phoglund@chromium.org.

The reason for reverting is: Still too slow for one of our win7 bots..

Powered by Google App Engine
This is Rietveld 408576698