[turbofan] Move node verification methods to the Verifier class.

src/compiler/node-properties.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/common-operator.h"
 #include "src/compiler/graph.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/operator-properties.h"
+#include "src/compiler/verifier.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 // static
 int NodeProperties::PastValueIndex(Node* node) {
   return FirstValueIndex(node) + node->op()->ValueInputCount();
 }
 
@@ skipping 172 matching lines @@
       DCHECK_NOT_NULL(value);
       edge.UpdateTo(value);
     }
   }
 }
 
 
 // static
 void NodeProperties::ChangeOp(Node* node, const Operator* new_op) {
   node->set_op(new_op);
-
-#ifdef DEBUG
-  Verify(node);
-#endif  // DEBUG
+  Verifier::VerifyNode(node);
 }
 
 
 // static
 Node* NodeProperties::FindProjection(Node* node, size_t projection_index) {
   for (auto use : node->uses()) {
     if (use->opcode() == IrOpcode::kProjection &&
         ProjectionIndexOf(use->op()) == projection_index) {
       return use;
     }
@@ skipping 49 matching lines @@
   }
 #ifdef DEBUG
   for (size_t index = 0; index < projection_count; ++index) {
     DCHECK_NOT_NULL(projections[index]);
   }
 #endif
 }
 
 
 // static
-void NodeProperties::Verify(Node* node) {
-  CHECK_EQ(OperatorProperties::GetTotalInputCount(node->op()),
-           node->InputCount());
-  // If this node has no effect or no control outputs,
-  // we check that no its uses are effect or control inputs.
-  bool check_no_control = node->op()->ControlOutputCount() == 0;
-  bool check_no_effect = node->op()->EffectOutputCount() == 0;
-  bool check_no_frame_state = node->opcode() != IrOpcode::kFrameState;
-  if (check_no_effect || check_no_control) {
-    for (Edge edge : node->use_edges()) {
-      Node* const user = edge.from();
-      CHECK(!user->IsDead());
-      if (NodeProperties::IsControlEdge(edge)) {
-        CHECK(!check_no_control);
-      } else if (NodeProperties::IsEffectEdge(edge)) {
-        CHECK(!check_no_effect);
-      } else if (NodeProperties::IsFrameStateEdge(edge)) {
-        CHECK(!check_no_frame_state);
-      }
-    }
-  }
-  // Frame state inputs should be frame states (or sentinels).
-  for (int i = 0; i < OperatorProperties::GetFrameStateInputCount(node->op());
-       i++) {
-    Node* input = NodeProperties::GetFrameStateInput(node, i);
-    CHECK(input->opcode() == IrOpcode::kFrameState ||
-          input->opcode() == IrOpcode::kStart ||
-          input->opcode() == IrOpcode::kDead);
-  }
-  // Effect inputs should be effect-producing nodes (or sentinels).
-  for (int i = 0; i < node->op()->EffectInputCount(); i++) {
-    Node* input = NodeProperties::GetEffectInput(node, i);
-    CHECK(input->op()->EffectOutputCount() > 0 ||
-          input->opcode() == IrOpcode::kDead);
-  }
-  // Control inputs should be control-producing nodes (or sentinels).
-  for (int i = 0; i < node->op()->ControlInputCount(); i++) {
-    Node* input = NodeProperties::GetControlInput(node, i);
-    CHECK(input->op()->ControlOutputCount() > 0 ||
-          input->opcode() == IrOpcode::kDead);
-  }
-}
-
-
-// static
 bool NodeProperties::AllValueInputsAreTyped(Node* node) {
   int input_count = node->op()->ValueInputCount();
   for (int index = 0; index < input_count; ++index) {
     if (!IsTyped(GetValueInput(node, index))) return false;
   }
   return true;
 }
 
 
 // static
 bool NodeProperties::IsInputRange(Edge edge, int first, int num) {
   if (num == 0) return false;
   int const index = edge.index();
   return first <= index && index < first + num;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8