Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1367403007: Speed up rounding to byte test (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
CC:
brucedawson
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : use float instead of double to avoid conversion #

Patch Set 3 : add 0.5f to round #

Patch Set 4 : lint fix and bump version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M README.chromium View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M unit_test/color_test.cc View 1 2 3 2 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
fbarchard1
5 years, 2 months ago (2015-10-02 18:27:03 UTC) #1
harryjin
lgtm
5 years, 2 months ago (2015-10-02 18:28:32 UTC) #2
fbarchard1
Profiler shows the actual unittest is half the bottleneck of this test, generating floats to ...
5 years, 2 months ago (2015-10-02 18:39:40 UTC) #3
brucedawson
https://codereview.chromium.org/1367403007/diff/1/unit_test/color_test.cc File unit_test/color_test.cc (right): https://codereview.chromium.org/1367403007/diff/1/unit_test/color_test.cc#newcode232 unit_test/color_test.cc:232: #define ROUND(f) lrintf(f) But, lrintf is ~376 times slower ...
5 years, 2 months ago (2015-10-02 18:48:07 UTC) #5
fbarchard1
Using float instead of double, and branchless, inner loop of test is faster 78: movaps ...
5 years, 2 months ago (2015-10-02 21:21:20 UTC) #6
fbarchard1
linux TestRoundToByte (2244 ms)
5 years, 2 months ago (2015-10-02 21:25:49 UTC) #7
fbarchard
On 2015/10/02 21:25:49, fbarchard1 wrote: > linux TestRoundToByte (2244 ms) On Windows Was TestRoundToByte (52299 ...
5 years, 2 months ago (2015-10-02 21:35:21 UTC) #8
fbarchard1
On 2015/10/02 21:35:21, fbarchard wrote: > On 2015/10/02 21:25:49, fbarchard1 wrote: > > linux TestRoundToByte ...
5 years, 2 months ago (2015-10-02 21:41:59 UTC) #9
fbarchard
switched back to cast but add 0.5f instead of 0.5 to avoid extra double to ...
5 years, 2 months ago (2015-10-02 21:44:53 UTC) #11
fbarchard
Visual C 32 bit generated this test loop 0F 28 EC movaps xmm5,xmm4 0000008D: F3 ...
5 years, 2 months ago (2015-10-02 21:54:37 UTC) #12
fbarchard
Visual C 32 bit TestRoundToByte (1179 ms) Visual C 64 bit TestRoundToByte (1419 ms) clangcl ...
5 years, 2 months ago (2015-10-02 22:20:16 UTC) #13
fbarchard1
5 years, 2 months ago (2015-10-02 22:27:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
f4c1ac10f02bb7346737bfcfd592ddfe866f2cf1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698