Issue 1367403004: Subzero: Add missing content to CfgLocalAllocator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1367403004: Subzero: Add missing content to CfgLocalAllocator. (Closed)

Created:
5 years, 2 months ago by Jim Stichnoth

Modified:
5 years, 2 months ago

Reviewers:
Karl, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Add missing content to CfgLocalAllocator. The std::list<> implementation used by g++ needs some extra stuff defined in the custom allocator. This can be smoke-tested with: make -f Makefile.standalone CXX=g++ LLVM_EXTRA_WARNINGS="-Wno-unknown-pragmas -Wno-unused-parameter -Wno-comment -Wno-enum-compare -Wno-strict-aliasing" STDLIB_FLAGS= until the link fails for unrelated reasons. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4325 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=91d1b80f69aa32922518606718753f5decdcb546

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	src/IceDefs.h	View		1 chunk	+12 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 2 months ago (2015-10-01 20:24:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
91d1b80f69aa32922518606718753f5decdcb546 (presubmit successful).