media/base/android/media_codec_decoder_unittest.cc - Issue 1367403003: Added UMA metrics for MediaSourcePlayer and MediaCodecPlayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_decoder_unittest.cc

Issue 1367403003: Added UMA metrics for MediaSourcePlayer and MediaCodecPlayer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mtplayer-drm

Patch Set: Addressed most of the comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/media_codec_decoder.cc ('K') | « media/base/android/media_codec_decoder.cc ('k') | media/base/android/media_codec_player.h » ('j') | media/base/android/media_codec_player.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_decoder_unittest.cc

diff --git a/media/base/android/media_codec_decoder_unittest.cc b/media/base/android/media_codec_decoder_unittest.cc

index 29d7012b61235564c2344166ff5f3d97168bce1c..21bebc7a6d3fdb78bd26a22d146d59e3a2446538 100644

--- a/media/base/android/media_codec_decoder_unittest.cc

+++ b/media/base/android/media_codec_decoder_unittest.cc

@@ -279,7 +279,8 @@ void MediaCodecDecoderTest::CreateAudioDecoder() {

base::Bind(&MediaCodecDecoderTest::OnKeyRequired, base::Unretained(this)),

base::Bind(&MediaCodecDecoderTest::OnError, base::Unretained(this)),

base::Bind(&MediaCodecDecoderTest::OnUpdateCurrentTime,

- base::Unretained(this))));

+ base::Unretained(this)),

+ nullptr));

data_available_cb_ = base::Bind(&MediaCodecDecoder::OnDemuxerDataAvailable,

base::Unretained(decoder_.get()));

@@ -300,7 +301,8 @@ void MediaCodecDecoderTest::CreateVideoDecoder() {

base::Bind(&MediaCodecDecoderTest::OnVideoSizeChanged,

base::Unretained(this)),

base::Bind(&MediaCodecDecoderTest::OnVideoCodecCreated,

- base::Unretained(this))));

+ base::Unretained(this)),

+ nullptr));

data_available_cb_ = base::Bind(&MediaCodecDecoder::OnDemuxerDataAvailable,

base::Unretained(decoder_.get()));