Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1367403002: Remove the GN *sdk targets (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Bons
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the GN *sdk targets Nobody actually needs to remove these, so I merged them with the runtime library configs that don't need to be referenced by the BUILDCONFIG.gn file. This adds a posix BUILD.gn file. More stuff from the compiler config can go here in the future. For now, it just has the sysroot setup for Posix. Committed: https://crrev.com/888b65f239fb3154c4adbe3fb3c42eae164f1031 Cr-Commit-Position: refs/heads/master@{#352077}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Fix comments #

Patch Set 5 : merge #

Patch Set 6 : asmflags update #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -84 lines) Patch
M .gn View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M build/config/BUILDCONFIG.gn View 1 2 3 4 2 chunks +0 lines, -11 lines 0 comments Download
M build/config/android/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -17 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M build/config/ios/BUILD.gn View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M build/config/linux/BUILD.gn View 1 chunk +5 lines, -15 lines 0 comments Download
D build/config/linux/sysroot_ld_path.py View 1 2 3 4 5 6 7 1 chunk +0 lines, -20 lines 0 comments Download
M build/config/mac/BUILD.gn View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
A build/config/posix/BUILD.gn View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A + build/config/posix/sysroot_ld_path.py View 1 2 3 4 5 6 7 0 chunks +-1 lines, --1 lines 0 comments Download
M build/config/win/BUILD.gn View 1 2 3 4 3 chunks +15 lines, -19 lines 0 comments Download

Messages

Total messages: 43 (21 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367403002/20001
5 years, 2 months ago (2015-09-28 05:05:01 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/9632)
5 years, 2 months ago (2015-09-28 05:07:11 UTC) #4
brettw
This is blocked by the deps roll: https://codereview.chromium.org/1370133006 (to get the configs loading the file ...
5 years, 2 months ago (2015-09-28 18:06:34 UTC) #6
Bons
https://codereview.chromium.org/1367403002/diff/40001/build/config/mac/BUILD.gn File build/config/mac/BUILD.gn (right): https://codereview.chromium.org/1367403002/diff/40001/build/config/mac/BUILD.gn#newcode10 build/config/mac/BUILD.gn:10: # that is Android-only. Please see that target for ...
5 years, 2 months ago (2015-09-28 18:09:46 UTC) #7
brettw
Comment fix patch up.
5 years, 2 months ago (2015-09-28 18:21:45 UTC) #8
Bons
On 2015/09/28 18:21:45, brettw wrote: > Comment fix patch up. lgtm
5 years, 2 months ago (2015-09-28 18:23:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367403002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367403002/60001
5 years, 2 months ago (2015-09-28 19:48:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367403002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367403002/60001
5 years, 2 months ago (2015-09-28 21:20:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/9995)
5 years, 2 months ago (2015-09-28 21:24:19 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367403002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367403002/60001
5 years, 2 months ago (2015-09-29 02:48:22 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/10155)
5 years, 2 months ago (2015-09-29 02:51:08 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367403002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367403002/100001
5 years, 2 months ago (2015-10-01 17:21:33 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/139566)
5 years, 2 months ago (2015-10-01 17:42:28 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367403002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367403002/120001
5 years, 2 months ago (2015-10-01 19:50:23 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/105098)
5 years, 2 months ago (2015-10-01 19:56:24 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367403002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367403002/120001
5 years, 2 months ago (2015-10-01 20:48:17 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/139712) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 2 months ago (2015-10-01 20:53:55 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367403002/10009 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367403002/10009
5 years, 2 months ago (2015-10-01 22:34:35 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/115405)
5 years, 2 months ago (2015-10-01 22:39:31 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367403002/10009 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367403002/10009
5 years, 2 months ago (2015-10-02 16:35:26 UTC) #41
commit-bot: I haz the power
Committed patchset #8 (id:10009)
5 years, 2 months ago (2015-10-02 18:00:34 UTC) #42
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 18:01:56 UTC) #43
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/888b65f239fb3154c4adbe3fb3c42eae164f1031
Cr-Commit-Position: refs/heads/master@{#352077}

Powered by Google App Engine
This is Rietveld 408576698