Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html

Issue 13674002: Support intrinsic values for height, min-height and max-height (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: CSS table tests Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html
diff --git a/LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html b/LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html
index 76944e3e4a5d9140e87b76ce8954e40ac425791e..46a5a9dc8a738f66f5c0b41b42907cf22257ad49 100644
--- a/LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html
+++ b/LayoutTests/fast/css-intrinsic-dimensions/height-property-value.html
@@ -4,22 +4,22 @@
-->
<script src="../js/resources/js-test-pre.js"></script>
-<div style="height: -webkit-min-content; min-height: -webkit-min-content; max-height: -webkit-min-content;"></div>
-<div style="height: -webkit-max-content; min-height: -webkit-max-content; max-height: -webkit-max-content;"></div>
-<div style="height: -webkit-fill-available; min-height: -webkit-fill-available; max-height: -webkit-fill-available;"></div>
-<div style="height: -webkit-fit-content; min-height: -webkit-fit-content; max-height: -webkit-fit-content;"></div>
+<div style="height: -webkit-min-content; min-height: -webkit-min-content; max-height: -webkit-min-content;" expected-data="min-content"></div>
+<div style="height: -webkit-max-content; min-height: -webkit-max-content; max-height: -webkit-max-content;" expected-data="max-content"></div>
+<div style="height: -webkit-fill-available; min-height: -webkit-fill-available; max-height: -webkit-fill-available;" expected-data="fill-available"></div>
+<div style="height: -webkit-fit-content; min-height: -webkit-fit-content; max-height: -webkit-fit-content;" expected-data="fit-content"></div>
<script>
- description('Tests that the height keywords are not exposed yet.');
+ description('Tests that the height keywords are parsed.');
+ var PREFIX = '-webkit-';
- var divs = document.querySelectorAll('div');
+ var divs = document.querySelectorAll('div.expected-data');
for (var i = 0; i < divs.length; ++i) {
- shouldBeEmptyString('divs[i].style.height');
- shouldBeEmptyString('divs[i].style.minHeight');
- shouldBeEmptyString('divs[i].style.maxHeight');
+ shouldBe('divs[i].style.height', 'PREFIX + divs[i].getAttribute("expected-data")');
+ shouldBe('divs[i].style.minHeight', 'PREFIX + divs[i].getAttribute("expected-data")');
+ shouldBe('divs[i].style.maxHeight', 'PREFIX + divs[i].getAttribute("expected-data")');
}
- var PREFIX = '-webkit-';
var KEYWORDS = ['min-content', 'max-content', 'fill-available', 'fit-content'];
var div;
@@ -28,9 +28,9 @@
div.style.height = PREFIX + keyword;
div.style.minHeight = PREFIX + keyword;
div.style.maxHeight = PREFIX + keyword;
- shouldBeEmptyString('div.style.height');
- shouldBeEmptyString('div.style.minHeight');
- shouldBeEmptyString('div.style.maxHeight');
+ shouldBe('div.style.height', '"' + PREFIX + keyword + '"');
+ shouldBe('div.style.minHeight', '"' + PREFIX + keyword + '"');
+ shouldBe('div.style.maxHeight', '"' + PREFIX + keyword + '"');
});
</script>

Powered by Google App Engine
This is Rietveld 408576698