Source/WebCore/css/CSSParser.h - Issue 13674002: Support intrinsic values for height, min-height and max-height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/css/CSSParser.h

Issue 13674002: Support intrinsic values for height, min-height and max-height (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: better fixme comment Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-intrinsic-dimensions/resources/height-keyword-classes.css ('K') | « LayoutTests/fast/css-intrinsic-dimensions/resources/height-keyword-classes.css ('k') | Source/WebCore/css/CSSParser.cpp » ('j') | Source/WebCore/css/CSSParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/css/CSSParser.h

diff --git a/Source/WebCore/css/CSSParser.h b/Source/WebCore/css/CSSParser.h

index b04c5e5305180cb9ff36b6c0c134888aa76b561f..be19f1e80b477d0b8ed87a1582c017f52d2eadfe 100644

--- a/Source/WebCore/css/CSSParser.h

+++ b/Source/WebCore/css/CSSParser.h

@@ -533,8 +533,7 @@ private:

void setupParser(const char* prefix, unsigned prefixLength, const String&, const char* suffix, unsigned suffixLength);

bool inShorthand() const { return m_inParseShorthand; }

- bool validWidth(CSSParserValue*);

- bool validHeight(CSSParserValue*);

+ bool validWidthOrHeight(CSSParserValue*);

void deleteFontFaceOnlyValues();