Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1367383002: Set |Channel::is_shutting_down_| during channel shutdown. (Closed)

Created:
5 years, 2 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set |Channel::is_shutting_down_| during channel shutdown. This flag is set by calling |Channel::WillShutdownSoon()|, but that may not be called in all cases (i.e. on broken connection due to renderer crash). crrev.com/95049185be27f0da5e9d2921a1be2b91f72b7956 relies on this flag being set on shutdown to prevent a race with |Channel::AttachAndRunEdpoint()|. Committed: https://crrev.com/3dd07db10b2c6c08bed268cb6447be34d6045a6e Cr-Commit-Position: refs/heads/master@{#351013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/mojo/src/mojo/edk/system/channel.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Mistry (off Chromium)
5 years, 2 months ago (2015-09-28 00:25:59 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 2 months ago (2015-09-28 01:06:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367383002/1
5 years, 2 months ago (2015-09-28 01:12:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 01:50:51 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 01:51:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dd07db10b2c6c08bed268cb6447be34d6045a6e
Cr-Commit-Position: refs/heads/master@{#351013}

Powered by Google App Engine
This is Rietveld 408576698