Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1367313002: Fix ChromeSwitches.DISABLE_FULLSCREEN to not overlap content. (Closed)

Created:
5 years, 2 months ago by Ted C
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ChromeSwitches.DISABLE_FULLSCREEN to not overlap content. I think with the ability to change toolbar heights at runtime, the fullscreen manager becomes required to ensure correct positioning. This just changes Tab to say it doesn't support hiding if the flag is set to true. BUG=535697 Committed: https://crrev.com/2c385058057430f90c07ebf2e2dced417c66fbc1 Cr-Commit-Position: refs/heads/master@{#351084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
5 years, 2 months ago (2015-09-25 23:46:40 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 2 months ago (2015-09-28 14:22:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367313002/1
5 years, 2 months ago (2015-09-28 15:59:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 16:38:47 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 16:39:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c385058057430f90c07ebf2e2dced417c66fbc1
Cr-Commit-Position: refs/heads/master@{#351084}

Powered by Google App Engine
This is Rietveld 408576698