Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 13673002: Make scoped_array<T> more compatible with scoped_ptr<T[]>. (Closed)

Created:
7 years, 8 months ago by dcheng
Modified:
7 years, 8 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

Make scoped_array<T> more compatible with scoped_ptr<T[]>. The eventual plan is to replace scoped_array<T> with scoped_ptr<T[]>. All existing issues with these new restrictions have been fixed, so I'd like to enforce them for scoped_array while the transition is still in progress. BUG=171118 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192528

Patch Set 1 #

Patch Set 2 : Being ambitious. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M base/memory/scoped_ptr.h View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
I thought I already disabled this for scoped_array<T>, but it turns out I forgot and ...
7 years, 8 months ago (2013-04-04 23:05:24 UTC) #1
darin (slow to review)
LGTM
7 years, 8 months ago (2013-04-05 06:22:35 UTC) #2
dcheng
7 years, 8 months ago (2013-04-05 07:57:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r192528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698