Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 136723010: Android WebView: initialize url_util safely. (Closed)

Created:
6 years, 11 months ago by Torne
Modified:
6 years, 11 months ago
Reviewers:
Kristian Monsen
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Android WebView: initialize url_util safely. In the case where we use CookieManager before initializing the rest of Chromium, we need to have initialized url_util at some reliable point because its lazy init is not threadsafe. Do this in the entry point so it's guaranteed we've always called it before any Chromium code runs. BUG=334490 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M android_webview/lib/main/webview_entry_point.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
6 years, 11 months ago (2014-01-15 22:24:20 UTC) #1
Kristian Monsen
lgtm, hope there are not more of these hidden trapdoors!
6 years, 11 months ago (2014-01-15 22:29:20 UTC) #2
Torne
On 2014/01/15 22:29:20, Kristian Monsen wrote: > lgtm, hope there are not more of these ...
6 years, 11 months ago (2014-01-15 22:30:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/136723010/1
6 years, 11 months ago (2014-01-15 22:52:28 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 03:12:40 UTC) #5
Message was sent while issue was closed.
Change committed as 245084

Powered by Google App Engine
This is Rietveld 408576698