Issue 136723007: Share more code between RenderSVGText and RenderSVGForeignObject

Issue 136723007: Share more code between RenderSVGText and RenderSVGForeignObject (Closed)

Created:
6 years, 11 months ago by rwlbuis

Modified:
6 years, 11 months ago

Reviewers:
pdr., f(malita)

CC:
blink-reviews, krit, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Share more code between RenderSVGText and RenderSVGForeignObject It turns out thse two classes share a lot of code, so move it to the common base class RenderSVGBlock Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165097

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -69 lines)			Patch
M	Source/core/rendering/svg/RenderSVGBlock.h	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGBlock.cpp	View		2 chunks	+27 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGForeignObject.h	View		3 chunks	+0 lines, -9 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGForeignObject.cpp	View		2 chunks	+0 lines, -26 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGText.h	View		3 chunks	+0 lines, -8 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGText.cpp	View		3 chunks	+0 lines, -26 lines	0 comments	Download

Total messages: 7 (0 generated)

rwlbuis

Simple refactor. Note that I still have to mark a few more methods FINAL but ...

6 years, 11 months ago (2014-01-14 17:00:30 UTC) #1

f(malita)

On 2014/01/14 17:00:30, rwlbuis wrote: > Simple refactor. Note that I still have to mark ...

6 years, 11 months ago (2014-01-14 17:08:53 UTC) #2

f(malita)

On 2014/01/14 17:08:53, Florin Malita wrote: > On 2014/01/14 17:00:30, rwlbuis wrote: > > Simple ...

6 years, 11 months ago (2014-01-14 17:45:33 UTC) #3

rwlbuis

On 2014/01/14 17:08:53, Florin Malita wrote: > On 2014/01/14 17:00:30, rwlbuis wrote: > > Simple ...

6 years, 11 months ago (2014-01-14 18:13:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/136723007/1

6 years, 11 months ago (2014-01-14 18:15:16 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/136723007/340001

6 years, 11 months ago (2014-01-14 18:55:41 UTC) #6

Message was sent while issue was closed.

Change committed as 165097