Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1367093002: I420Alpha row function in 1 pass (Closed)

Created:
5 years, 3 months ago by fbarchard1
Modified:
5 years, 2 months ago
Reviewers:
harryjin, fbarchard
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

I420Alpha row function in 1 pass. API change - I420AlphaToARGB takes flag indicating if RGB should be premultiplied by alpha. This version implements an efficient SSSE3 version for Windows. C version done in 2 steps. Was libyuvTest.I420AlphaToARGB_Any (1136 ms) libyuvTest.I420AlphaToARGB_Unaligned (1210 ms) libyuvTest.I420AlphaToARGB_Invert (966 ms) libyuvTest.I420AlphaToARGB_Opt (1031 ms) libyuvTest.I420AlphaToABGR_Any (1020 ms) libyuvTest.I420AlphaToABGR_Unaligned (1359 ms) libyuvTest.I420AlphaToABGR_Invert (1082 ms) libyuvTest.I420AlphaToABGR_Opt (986 ms) R=harryjin@google.com BUG=libyuv:496 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/e365cdde3b18f8c109c9d6319dbfb5c493c242e6

Patch Set 1 #

Total comments: 2

Patch Set 2 : add attenuate flag and test #

Patch Set 3 : bump version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+261 lines, -92 lines) Patch
M README.chromium View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/convert_argb.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M include/libyuv/row.h View 1 2 5 chunks +51 lines, -0 lines 0 comments Download
M include/libyuv/version.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M source/convert_argb.cc View 1 2 6 chunks +49 lines, -80 lines 0 comments Download
M source/row_any.cc View 1 2 2 chunks +29 lines, -1 line 0 comments Download
M source/row_common.cc View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M source/row_win.cc View 1 2 2 chunks +96 lines, -0 lines 0 comments Download
M unit_test/convert_test.cc View 1 4 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
fbarchard1
5 years, 3 months ago (2015-09-25 01:53:57 UTC) #1
fbarchard
SSSE3 version of I420AlphaToARGB for Windows. Was I420AlphaToARGB_Opt (959 ms) Now I420AlphaToARGB_Opt (800 ms)
5 years, 3 months ago (2015-09-25 01:56:02 UTC) #3
harryjin
https://codereview.chromium.org/1367093002/diff/1/source/convert_argb.cc File source/convert_argb.cc (right): https://codereview.chromium.org/1367093002/diff/1/source/convert_argb.cc#newcode362 source/convert_argb.cc:362: // I422AlphaToARGBRow = I422AlphaToARGBRow_Any_SSSE3; Remove?
5 years, 3 months ago (2015-09-25 01:59:13 UTC) #4
fbarchard
Was libyuvTest.I420AlphaToARGB_Any (1136 ms) libyuvTest.I420AlphaToARGB_Unaligned (1210 ms) libyuvTest.I420AlphaToARGB_Invert (966 ms) libyuvTest.I420AlphaToARGB_Opt (1031 ms) libyuvTest.I420AlphaToABGR_Any (1020 ...
5 years, 3 months ago (2015-09-25 02:54:58 UTC) #5
harryjin
lgtm
5 years, 2 months ago (2015-09-25 16:46:23 UTC) #6
fbarchard1
5 years, 2 months ago (2015-09-25 17:29:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e365cdde3b18f8c109c9d6319dbfb5c493c242e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698