components/bookmarks/browser/bookmark_model.cc - Issue 1367063004: Support undoing offline page deletion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_model.cc

Issue 1367063004: Support undoing offline page deletion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Filip's feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks/browser/bookmark_model.cc

diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmarks/browser/bookmark_model.cc

index 5709533dba2d0be60f7f29ded432599ba10be75a..19cdc6b8173e80754a5a82fc8d8d195e83a9a621 100644

--- a/components/bookmarks/browser/bookmark_model.cc

+++ b/components/bookmarks/browser/bookmark_model.cc

@@ -469,6 +469,11 @@ void BookmarkModel::OnFaviconsChanged(const std::set<GURL>& page_urls,

}

+void BookmarkModel::OnBookmarkRenumbered(int64 old_id, int64 new_id) {

+ FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,

+ BookmarkNodeRenumbered(this, old_id, new_id));

void BookmarkModel::SetDateAdded(const BookmarkNode* node, Time date_added) {

DCHECK(node && !is_permanent_node(node));