chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageStorageSpacePolicy.java - Issue 1367063004: Support undoing offline page deletion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageStorageSpacePolicy.java

Issue 1367063004: Support undoing offline page deletion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageStorageSpacePolicy.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageStorageSpacePolicy.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageStorageSpacePolicy.java

index 68732e6b33d9cb195f9778636c00df0a89d74af9..c505fcb99f9909a75351abafb709330d062ad724 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageStorageSpacePolicy.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageStorageSpacePolicy.java

@@ -39,8 +39,8 @@ public class OfflinePageStorageSpacePolicy {

* storage and offer freeing up space.

public boolean shouldShowStorageSpaceHeader() {

- return getSizeOfAllPages() > MINIMUM_TOTAL_SIZE_BYTES

- && getSizeOfPagesToCleanUp() > MINIMUM_CLEANUP_SIZE_BYTES;

+ return true; /*getSizeOfAllPages() > MINIMUM_TOTAL_SIZE_BYTES

fgorski 2015/09/25 20:30:50 Is this correct?

jianli 2015/09/25 20:52:35 Sorry, I forgot to remove this testing change.

+ && getSizeOfPagesToCleanUp() > MINIMUM_CLEANUP_SIZE_BYTES;*/

}

/** @return Total size, in bytes, of all saved pages. */

« no previous file with comments | « no previous file | components/bookmarks/browser/bookmark_model.h » ('j') | components/bookmarks/browser/bookmark_model.h » ('J')