components/bookmarks/browser/bookmark_model.cc - Issue 1367063004: Support undoing offline page deletion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/bookmarks/browser/bookmark_model.cc

Issue 1367063004: Support undoing offline page deletion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/bookmarks/browser/bookmark_model.h ('K') | « components/bookmarks/browser/bookmark_model.h ('k') | components/bookmarks/browser/bookmark_model_observer.h » ('j') | components/bookmarks/browser/bookmark_model_observer.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/bookmarks/browser/bookmark_model.h"	5 #include "components/bookmarks/browser/bookmark_model.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

8 #include <functional>	8 #include <functional>

9	9

10 #include "base/bind.h"	10 #include "base/bind.h"

(...skipping 1030 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1041 CreatePermanentNode(BookmarkNode::MOBILE);	1041 CreatePermanentNode(BookmarkNode::MOBILE);

1042 return scoped_ptr<BookmarkLoadDetails>(new BookmarkLoadDetails(	1042 return scoped_ptr<BookmarkLoadDetails>(new BookmarkLoadDetails(

1043 bb_node,	1043 bb_node,

1044 other_node,	1044 other_node,

1045 mobile_node,	1045 mobile_node,

1046 client_->GetLoadExtraNodesCallback(),	1046 client_->GetLoadExtraNodesCallback(),

1047 new BookmarkIndex(client_, accept_languages),	1047 new BookmarkIndex(client_, accept_languages),

1048 next_node_id_));	1048 next_node_id_));

1049 }	1049 }

1050	1050

	1051 void BookmarkModel::OnBookmarkRenumbered(int64 old_id, int64 new_id) {
	sky 2015/09/25 15:54:44 Make position of declaration/definition match. Make position of declaration/definition match. jianli 2015/09/25 20:29:24 Done. Show quoted text On 2015/09/25 15:54:44, sky wrote: > Make position of declaration/definition match. Done.
	1052 FOR_EACH_OBSERVER(BookmarkModelObserver, observers_,

	1053 BookmarkNodeRenumbered(this, old_id, new_id));

	1054 }

	1055

1051 } // namespace bookmarks	1056 } // namespace bookmarks

OLD	NEW