fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp - Issue 1367033002: Pass v8::Isolate to PDFium at init time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

Issue 1367033002: Pass v8::Isolate to PDFium at init time. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: fix leak, clear globals while we're at it. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

diff --git a/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp b/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

index 7726c40c5e1a898189b4099d826ca97f8d637488..1c660397d1914aa3f0c12ce843f3522e87476433 100644

--- a/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

+++ b/fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp

@@ -30,7 +30,7 @@ class FXJSV8Embeddertest : public EmbedderTest {

v8::Isolate::Scope isolate_scope(m_pIsolate);

v8::HandleScope handle_scope(m_pIsolate);

- FXJS_Initialize(0);

+ FXJS_Initialize(0, nullptr);

FXJS_PerIsolateData::SetUp(m_pIsolate);

FXJS_InitializeRuntime(m_pIsolate, nullptr, nullptr, m_pPersistentContext);

}