Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 136703005: Return an error on Multiple AUs in a PES. (Closed)

Created:
6 years, 11 months ago by Anjali
Modified:
6 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Return an error on Multiple AUs in a PES. HLS spec recommends a single access unit(AU) in a packetized elementary stream(PES) so that each access unit can be assigned a unique PTS and DTS. The change makes es_parser_h264 return an error if the AU cannot be assigned a PTS and DTS. BUG=254214 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245347

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed extra blank line as per review comment. #

Total comments: 1

Patch Set 3 : Documented return value of EmitFrameIfNeeded #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M media/mp2t/es_parser_h264.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M media/mp2t/es_parser_h264.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
damienv1
https://codereview.chromium.org/136703005/diff/1/media/mp2t/es_parser_h264.cc File media/mp2t/es_parser_h264.cc (right): https://codereview.chromium.org/136703005/diff/1/media/mp2t/es_parser_h264.cc#newcode237 media/mp2t/es_parser_h264.cc:237: nit: blank line not needed (otherwise the previous comment ...
6 years, 11 months ago (2014-01-16 01:05:54 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm % nit https://codereview.chromium.org/136703005/diff/60001/media/mp2t/es_parser_h264.h File media/mp2t/es_parser_h264.h (right): https://codereview.chromium.org/136703005/diff/60001/media/mp2t/es_parser_h264.h#newcode58 media/mp2t/es_parser_h264.h:58: bool EmitFrameIfNeeded(int next_aud_pos); nit: Please document ...
6 years, 11 months ago (2014-01-16 01:31:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anjalibh@google.com/136703005/130001
6 years, 11 months ago (2014-01-16 20:43:04 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 22:09:48 UTC) #4
Message was sent while issue was closed.
Change committed as 245347

Powered by Google App Engine
This is Rietveld 408576698