Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 136703002: Handlify AllocationSite AddDependentCompilationInfo. (Closed)

Created:
6 years, 11 months ago by Hannes Payer (out of office)
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Handlify AllocationSite AddDependentCompilationInfo. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18570

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -29 lines) Patch
M src/hydrogen.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M src/objects.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 chunks +7 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
6 years, 11 months ago (2014-01-13 14:12:40 UTC) #1
mvstanton
lgtm. https://codereview.chromium.org/136703002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/136703002/diff/1/src/objects.cc#newcode12881 src/objects.cc:12881: // static nit: I don't think we usually ...
6 years, 11 months ago (2014-01-13 14:37:56 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/136703002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/136703002/diff/1/src/objects.cc#newcode12898 src/objects.cc:12898: if (*codes != dependent_code()) set_dependent_code(*codes); Please remove this method.
6 years, 11 months ago (2014-01-13 14:38:46 UTC) #3
Hannes Payer (out of office)
https://codereview.chromium.org/136703002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/136703002/diff/1/src/objects.cc#newcode12881 src/objects.cc:12881: // static On 2014/01/13 14:37:56, mvstanton wrote: > nit: ...
6 years, 11 months ago (2014-01-13 14:53:20 UTC) #4
Hannes Payer (out of office)
6 years, 11 months ago (2014-01-13 14:54:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698