Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: ipc/attachment_broker.cc

Issue 1367013003: ipc: Change the timing of the construction of the attachment broker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from tsepez. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/child_process_host_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/attachment_broker.cc
diff --git a/ipc/attachment_broker.cc b/ipc/attachment_broker.cc
index 362fc1f52235b138553dd6d1d33effdd8d7a79a5..7e04bcd645de09dd4a4a32e3cd8f6198c567926d 100644
--- a/ipc/attachment_broker.cc
+++ b/ipc/attachment_broker.cc
@@ -14,10 +14,7 @@ namespace IPC {
// static
void AttachmentBroker::SetGlobal(AttachmentBroker* broker) {
- // TODO(erikchen): There should be a CHECK here to make sure that
- // |g_attachment_broker| is nullptr. Right now, this causes problems with
- // --single_process and similar testing conditions. I'm temporarily removing
- // this CHECK. http://crbug.com/534539.
+ CHECK(!g_attachment_broker);
g_attachment_broker = broker;
}
« no previous file with comments | « content/common/child_process_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698