Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1367003002: Add missing Count api (Closed)

Created:
5 years, 3 months ago by iannucci
Modified:
5 years, 3 months ago
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@move_serialization_helpers
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -29 lines) Patch
M filter/count/rds.go View 2 chunks +6 lines, -0 lines 0 comments Download
M filter/featureBreaker/rds.go View 1 chunk +9 lines, -0 lines 0 comments Download
M impl/dummy/dummy.go View 1 chunk +1 line, -0 lines 0 comments Download
M impl/memory/datastore.go View 2 chunks +9 lines, -0 lines 0 comments Download
M impl/memory/datastore_query_execution.go View 1 chunk +14 lines, -0 lines 0 comments Download
M impl/memory/datastore_query_execution_test.go View 3 chunks +49 lines, -27 lines 0 comments Download
M impl/prod/raw_datastore.go View 3 chunks +10 lines, -1 line 0 comments Download
M impl/prod/raw_datastore_type_converter_test.go View 2 chunks +9 lines, -1 line 1 comment Download
M service/datastore/datastore.go View 1 chunk +8 lines, -0 lines 0 comments Download
M service/datastore/interface.go View 1 chunk +4 lines, -0 lines 0 comments Download
M service/datastore/raw_interface.go View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1365743002 Patch 40001

Messages

Total messages: 6 (1 generated)
iannucci
5 years, 3 months ago (2015-09-24 19:36:51 UTC) #1
Vadim Sh.
lgtm https://codereview.chromium.org/1367003002/diff/1/impl/prod/raw_datastore_type_converter_test.go File impl/prod/raw_datastore_type_converter_test.go (right): https://codereview.chromium.org/1367003002/diff/1/impl/prod/raw_datastore_type_converter_test.go#newcode5 impl/prod/raw_datastore_type_converter_test.go:5: // +build appengine I didn't notice this before... ...
5 years, 3 months ago (2015-09-24 19:46:21 UTC) #2
iannucci
On 2015/09/24 at 19:46:21, vadimsh wrote: > lgtm > > https://codereview.chromium.org/1367003002/diff/1/impl/prod/raw_datastore_type_converter_test.go > File impl/prod/raw_datastore_type_converter_test.go (right): ...
5 years, 3 months ago (2015-09-24 19:47:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367003002/1
5 years, 3 months ago (2015-09-24 19:49:11 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 19:50:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/2b63080f0444d2ab13120092c7d71f6de5ed8ba7

Powered by Google App Engine
This is Rietveld 408576698