Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3773)

Unified Diff: chrome/browser/search/hotword_service_factory.cc

Issue 136693013: [Hotword] Remove unneeded preferences. Cleaning up look of settings. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: wrong section name in test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/hotword_service_factory.cc
diff --git a/chrome/browser/search/hotword_service_factory.cc b/chrome/browser/search/hotword_service_factory.cc
index 0cc83f826aa804afdce53171557ac1fd25b8bc9b..a34d4135d0ec26af235c15b768e0ec9c3f3fe2bd 100644
--- a/chrome/browser/search/hotword_service_factory.cc
+++ b/chrome/browser/search/hotword_service_factory.cc
@@ -16,9 +16,7 @@
HotwordService* HotwordServiceFactory::GetForProfile(Profile* profile) {
if (!profile ||
(profile->GetPrefs()->HasPrefPath(prefs::kHotwordSearchEnabled) &&
- !profile->GetPrefs()->GetBoolean(prefs::kHotwordSearchEnabled)) ||
- (profile->IsOffTheRecord() &&
- !profile->GetPrefs()->GetBoolean(prefs::kHotwordSearchIncognitoEnabled)))
+ !profile->GetPrefs()->GetBoolean(prefs::kHotwordSearchEnabled)))
return NULL;
return static_cast<HotwordService*>(
@@ -51,20 +49,9 @@ void HotwordServiceFactory::RegisterProfilePrefs(
prefs->RegisterBooleanPref(prefs::kHotwordSearchEnabled,
false,
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
- prefs->RegisterBooleanPref(prefs::kHotwordSearchIncognitoEnabled,
- false,
- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
prefs->RegisterIntegerPref(prefs::kHotwordOptInPopupTimesShown,
0,
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
- prefs->RegisterBooleanPref(prefs::kHotwordSearchTimeoutEnabled,
- true,
- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
-}
-
-content::BrowserContext* HotwordServiceFactory::GetBrowserContextToUse(
- content::BrowserContext* context) const {
- return chrome::GetBrowserContextOwnInstanceInIncognito(context);
}
BrowserContextKeyedService* HotwordServiceFactory::BuildServiceInstanceFor(
« no previous file with comments | « chrome/browser/search/hotword_service_factory.h ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698