Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2828)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 136693013: [Hotword] Remove unneeded preferences. Cleaning up look of settings. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: wrong section name in test Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 14926d3e1cd1c7b48b0bd78f8adbbe25baf3afb1..8648bf030b721d1a1eb888fa78d29184c4009098 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -128,8 +128,6 @@ cr.define('options', function() {
OptionsPage.navigateToPage('homePageOverlay');
};
- Preferences.getInstance().addEventListener('hotword.search_enabled',
- this.onHotwordSearchPrefChanged_.bind(this));
chrome.send('requestHotwordAvailabile');
if ($('set-wallpaper')) {
@@ -890,24 +888,6 @@ cr.define('options', function() {
},
/**
- * Event listener for the 'hotword search enabled' preference. Shows/hides
- * the UI for updating hotword settings..
- * @param {Event} event The preference change event.
- */
- onHotwordSearchPrefChanged_: function(event) {
- var section = $('hotword-settings-section');
- var container = $('hotword-settings-section-container');
- // event.value is a dictionary with details about the preference that was
- // changed. Within that dictionary, |value| is the new value of the
- // preference. In this case, the preference represents a Boolean so it
- // can be checked for true/false.
- if (event.value.value)
- this.showSectionWithAnimation_(section, container);
- else
- this.hideSectionWithAnimation_(section, container);
- },
-
- /**
* Event listener for the 'homepage is NTP' preference. Updates the label
* next to the 'Change' button.
* @param {Event} event The preference change event.
« no previous file with comments | « chrome/browser/resources/options/browser_options.html ('k') | chrome/browser/resources/options/hotword_confirm_overlay.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698