pkg/stack_trace/lib/src/trace.dart - Issue 136693006: Support Safari 6.1 stack traces with blank lines in pkg/stack_trace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/stack_trace/lib/src/trace.dart

Issue 136693006: Support Safari 6.1 stack traces with blank lines in pkg/stack_trace. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/stack_trace/lib/src/trace.dart

diff --git a/pkg/stack_trace/lib/src/trace.dart b/pkg/stack_trace/lib/src/trace.dart

index 45cb42c757a2e295631b8ce5d7d91c1c49c851f0..21e8afcfced678ad0314ac7eb034f4fea2761f29 100644

--- a/pkg/stack_trace/lib/src/trace.dart

+++ b/pkg/stack_trace/lib/src/trace.dart

@@ -164,6 +164,7 @@ class Trace implements StackTrace {

/// Parses a string representation of a Safari 6.1+ stack trace.

Trace.parseSafari6_1(String trace)

: this(trace.trim().split("\n")

+ .where((line) => line.isNotEmpty)

.map((line) => new Frame.parseSafari6_1(line)));

/// Parses a string representation of a Safari 6.0 stack trace.

« no previous file with comments | « no previous file | pkg/stack_trace/test/trace_test.dart » ('j') | no next file with comments »